Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: sdk/lib/_internal/js_runtime/lib/js_helper.dart

Issue 1346133002: Report hint on unmatched show and hide combinators. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Remove line-ending changes. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/js_runtime/lib/js_helper.dart
diff --git a/sdk/lib/_internal/js_runtime/lib/js_helper.dart b/sdk/lib/_internal/js_runtime/lib/js_helper.dart
index b4ab91c192b236631901ea56dfd63960692ea18a..422a5bc7abb72071b489cf3c0d0a24337319dbdc 100644
--- a/sdk/lib/_internal/js_runtime/lib/js_helper.dart
+++ b/sdk/lib/_internal/js_runtime/lib/js_helper.dart
@@ -18,8 +18,7 @@ import 'dart:_js_embedded_names' show
JsGetName,
LEAF_TAGS,
NATIVE_SUPERCLASS_TAG_NAME,
- STATIC_FUNCTION_NAME_PROPERTY_NAME,
- TRACE_BUFFER;
+ STATIC_FUNCTION_NAME_PROPERTY_NAME;
import 'dart:collection';
@@ -45,13 +44,11 @@ import 'dart:_foreign_helper' show
JS_BUILTIN,
JS_CALL_IN_ISOLATE,
JS_CONST,
- JS_GET_STATIC_STATEC,
JS_CURRENT_ISOLATE_CONTEXT,
JS_EFFECT,
JS_EMBEDDED_GLOBAL,
JS_GET_FLAG,
JS_GET_NAME,
- JS_HAS_EQUALS,
JS_STRING_CONCAT,
RAW_DART_FUNCTION_REF;
@@ -1566,7 +1563,7 @@ ioore(receiver, index) {
*/
@NoInline()
Error diagnoseIndexError(indexable, index) {
- if (index is! int) return new ArgumentError.value(index, 'index');
+ if (index is !int) return new ArgumentError.value(index, 'index');
int length = indexable.length;
// The following returns the same error that would be thrown by calling
// [RangeError.checkValidIndex] with no optional parameters provided.
« no previous file with comments | « sdk/lib/_internal/js_runtime/lib/isolate_patch.dart ('k') | sdk/lib/_internal/js_runtime/lib/js_mirrors.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698