Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 1345413002: dart2js ssa: Inlining heuristics ignore assert() statement size. (Closed)

Created:
5 years, 3 months ago by sra1
Modified:
5 years, 3 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js ssa: Inlining heuristics ignore assert() statement size. assert() Ast nodes are not counted towards inlinee size in production mode. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/a2239c2deeeb8e8fd1d6fe5d1fde6dc275d576b3

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -7 lines) Patch
M pkg/compiler/lib/src/ssa/builder.dart View 5 chunks +23 lines, -7 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/js_rti.dart View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
I didn't see any regressions from the @NoInline()
5 years, 3 months ago (2015-09-17 03:43:59 UTC) #3
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1345413002/diff/20001/sdk/lib/_internal/js_runtime/lib/js_rti.dart File sdk/lib/_internal/js_runtime/lib/js_rti.dart (right): https://codereview.chromium.org/1345413002/diff/20001/sdk/lib/_internal/js_runtime/lib/js_rti.dart#newcode97 sdk/lib/_internal/js_runtime/lib/js_rti.dart:97: // creates an object that already has the ...
5 years, 3 months ago (2015-09-17 16:10:10 UTC) #4
sra1
5 years, 3 months ago (2015-09-17 16:44:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
a2239c2deeeb8e8fd1d6fe5d1fde6dc275d576b3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698