dart2js ssa: Inlining heuristics ignore assert() statement size.

sdk/lib/_internal/js_runtime/lib/js_rti.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * This part contains helpers for supporting runtime type information.
  *
  * The helper use a mixture of Dart and JavaScript objects. To indicate which is
  * used where we adopt the scheme of using explicit type annotation for Dart
  * objects and 'var' or omitted return type for JavaScript objects.
@@ skipping 67 matching lines @@
   const TypeVariable(this.owner, this.name, this.bound);
 }
 
 getMangledTypeName(TypeImpl type) => type._typeName;
 
 /**
  * Sets the runtime type information on [target]. [rti] is a type
  * representation of type 4 or 5, that is, either a JavaScript array or
  * `null`.
  */
+// Don't inline.  Let the JS engine inline this.  The call expression is much
+// more compact that the inlined expansion.
+// TODO(sra): For most objects it would be better to initialize the type info as
+// a field in the constructor: http://dartbug.com/22676 .
+@NoInline()
 Object setRuntimeTypeInfo(Object target, var rti) {
   assert(rti == null || isJsArray(rti));
   // We have to check for null because factories may return null.
+  // TODO(sra): How is this true? The factory should be executing some code that
+  // creates an object that already has the correct info.

[Siggi Cherem (dart-lang), 2015/09/17 16:10:10]

do you mean that we would never invoke setRuntimeTypeInfo on the result of a
factory method, but that the call would happen when the actual allocation is
made? Or are we calling setRuntimeTypeInfo twice in that case?

   if (target != null) JS('var', r'#.$builtinTypeInfo = #', target, rti);
   return target;
 }
 
 /**
  * Returns the runtime type information of [target]. The returned value is a
  * list of type representations for the type arguments.
  */
 getRuntimeTypeInfo(Object target) {
   if (target == null) return null;
@@ skipping 571 matching lines @@
  * `null` and `undefined` (which we can avoid).
  */
 bool isIdentical(var s, var t) => JS('bool', '# === #', s, t);
 
 /**
  * Returns `true` if the JavaScript values [s] and [t] are not identical. We use
  * this helper instead of [identical] because `identical` needs to merge
  * `null` and `undefined` (which we can avoid).
  */
 bool isNotIdentical(var s, var t) => JS('bool', '# !== #', s, t);