ARM & MIPS: Try to use the object pool before trying to embed a pointer, like ARM64 and X64.

ARM & MIPS: Try to use the object pool before trying to embed a pointer, like ARM64 and X64.

(In particular, don't embed pointers to arguments descriptors.)

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/13e0a49d478efb08ea9abfdb6a3a906b2e8ee712

[rmacnak, 2015-09-15 23:18:32]

rmacnak@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2015-09-16 08:00:05]

lgtm

https://codereview.chromium.org/1344153002/diff/20001/runtime/vm/assembler_ar...
File runtime/vm/assembler_arm.cc (right):

https://codereview.chromium.org/1344153002/diff/20001/runtime/vm/assembler_ar...
runtime/vm/assembler_arm.cc:1606: // Make sure that class CallPattern is able to
decode this load immediate.
I don't think the comment applies to this case since CallPattern only recognizes
loads from the constant pool.

https://codereview.chromium.org/1344153002/diff/20001/runtime/vm/assembler_mi...
File runtime/vm/assembler_mips.cc (right):

https://codereview.chromium.org/1344153002/diff/20001/runtime/vm/assembler_mi...
runtime/vm/assembler_mips.cc:542: // Make sure that class CallPattern is able to
decode this load immediate.
Comment does not apply here.

[rmacnak, 2015-09-16 17:09:43]

https://codereview.chromium.org/1344153002/diff/20001/runtime/vm/assembler_ar...
File runtime/vm/assembler_arm.cc (right):

https://codereview.chromium.org/1344153002/diff/20001/runtime/vm/assembler_ar...
runtime/vm/assembler_arm.cc:1606: // Make sure that class CallPattern is able to
decode this load immediate.
On 2015/09/16 08:00:05, Florian Schneider wrote:
> I don't think the comment applies to this case since CallPattern only
recognizes
> loads from the constant pool.

Hm, CallPattern expects a constant pool load in its constructor but either a
constant pool load or immediate load in IcData(). I'll create another CL to
remove the immediate load case.

[rmacnak, 2015-09-16 17:18:42]

Committed patchset #2 (id:20001) manually as
13e0a49d478efb08ea9abfdb6a3a906b2e8ee712 (presubmit successful).