Issue 13430008: Only use special method to send messages to helper isolate.

Issue 13430008: Only use special method to send messages to helper isolate. (Closed)

Created:
7 years, 8 months ago by Anton Muhin

Modified:
7 years, 8 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Only use special method to send messages to helper isolate. R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=20791

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -56 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		2 chunks	+1 line, -16 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		4 chunks	+23 lines, -20 lines	0 comments	Download
M	tools/dom/src/Timer.dart	View		2 chunks	+1 line, -16 lines	0 comments	Download
M	tools/dom/src/native_DOMImplementation.dart	View	1	2 chunks	+22 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

vsm

lgtm https://codereview.chromium.org/13430008/diff/1/tools/dom/src/native_DOMImplementation.dart File tools/dom/src/native_DOMImplementation.dart (right): https://codereview.chromium.org/13430008/diff/1/tools/dom/src/native_DOMImplementation.dart#newcode139 tools/dom/src/native_DOMImplementation.dart:139: // Once _HELPER_ISOLATE_PORT gets resolved, it will still ...

7 years, 8 months ago (2013-04-02 16:08:30 UTC) #2

Anton Muhin

https://codereview.chromium.org/13430008/diff/1/tools/dom/src/native_DOMImplementation.dart File tools/dom/src/native_DOMImplementation.dart (right): https://codereview.chromium.org/13430008/diff/1/tools/dom/src/native_DOMImplementation.dart#newcode139 tools/dom/src/native_DOMImplementation.dart:139: // Once _HELPER_ISOLATE_PORT gets resolved, it will still delay ...

7 years, 8 months ago (2013-04-02 16:17:49 UTC) #3

Anton Muhin

7 years, 8 months ago (2013-04-02 16:34:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r20791 (presubmit successful).

Expand Messages | Collapse Messages