Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Issue 13430008: Only use special method to send messages to helper isolate. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dart2js/html_dart2js.dart
diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart
index 06214ba0e495c06983329e4ede952ecc08942a29..95c8ab0732542b22c791417b26ccd2f72b485a1d 100644
--- a/sdk/lib/html/dart2js/html_dart2js.dart
+++ b/sdk/lib/html/dart2js/html_dart2js.dart
@@ -32756,7 +32756,6 @@ class Rect {
// BSD-style license that can be found in the LICENSE file.
-// TODO(antonm): support not DOM isolates too.
class _Timer implements Timer {
final canceller;
@@ -32807,22 +32806,8 @@ class _PureIsolateTimer implements Timer {
_port.close();
}
- // Tricky part.
- // Once _HELPER_ISOLATE_PORT gets resolved, it will still delay in .then
- // and to delay Timer.run is used. However, Timer.run will try to register
- // another Timer and here we got stuck: event cannot be posted as then
- // callback is not executed because it's delayed with timer.
- // Therefore once future is resolved, it's unsafe to call .then on it
- // in Timer code.
_send(msg) {
- if (_SEND_PORT != null) {
- _SEND_PORT.send(msg, _sendPort);
- } else {
- _HELPER_ISOLATE_PORT.then((port) {
- _SEND_PORT = port;
- _SEND_PORT.send(msg, _sendPort);
- });
- }
+ _sendToHelperIsolate(msg, _sendPort);
}
}
« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698