Issue 1341723003: Add an extension point for contributing to HTML_ERRORS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1341723003: Add an extension point for contributing to HTML_ERRORS. (Closed)

Created:
5 years, 3 months ago by scheglov

Modified:
5 years, 3 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add an extension point for contributing to HTML_ERRORS. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/e878562d356bfb16fbd8ba680d0bde061dc3ef6b

Patch Set 1 #

Total comments: 1

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -33 lines)			Patch
M	pkg/analyzer/lib/plugin/task.dart	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/plugin/engine_plugin.dart	View	8 chunks	+37 lines, -6 lines	0 comments	Download
M	pkg/analyzer/lib/src/task/html.dart	View	4 chunks	+18 lines, -15 lines	1 comment	Download
M	pkg/analyzer/test/src/task/html_test.dart	View	1 chunk	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1341723003/diff/1/pkg/analyzer/lib/src/task/html.dart File pkg/analyzer/lib/src/task/html.dart (right): https://codereview.chromium.org/1341723003/diff/1/pkg/analyzer/lib/src/task/html.dart#newcode220 pkg/analyzer/lib/src/task/html.dart:220: String inputName = result.name + '_input'; '_input' should ...

5 years, 3 months ago (2015-09-14 18:55:35 UTC) #2

scheglov

5 years, 3 months ago (2015-09-14 19:00:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e878562d356bfb16fbd8ba680d0bde061dc3ef6b (presubmit successful).

Expand Messages | Collapse Messages