Add an extension point for contributing to HTML_ERRORS.

pkg/analyzer/lib/src/task/html.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.src.task.html;
 
 import 'dart:collection';
 
 import 'package:analyzer/src/generated/engine.dart' hide AnalysisTask;
 import 'package:analyzer/src/generated/error.dart';
 import 'package:analyzer/src/generated/source.dart';
 import 'package:analyzer/src/task/dart.dart';
 import 'package:analyzer/src/task/general.dart';
 import 'package:analyzer/task/dart.dart';
 import 'package:analyzer/task/general.dart';
 import 'package:analyzer/task/html.dart';
 import 'package:analyzer/task/model.dart';
 import 'package:html/dom.dart';
 import 'package:html/parser.dart';
 import 'package:source_span/source_span.dart';
 import 'package:analyzer/src/context/cache.dart';
 import 'package:analyzer/src/generated/java_engine.dart';
 import 'package:analyzer/src/generated/scanner.dart';
+import 'package:analyzer/src/plugin/engine_plugin.dart';
 
 /**
  * The Dart scripts that are embedded in an HTML file.
  */
 final ListResultDescriptor<DartScript> DART_SCRIPTS =
     new ListResultDescriptor<DartScript>('DART_SCRIPTS', DartScript.EMPTY_LIST);
 
 /**
  * The errors found while parsing an HTML file.
  */
@@ skipping 155 matching lines @@
  * of errors.
  */
 class HtmlErrorsTask extends SourceBasedAnalysisTask {
   /**
    * The name of the input that is a list of errors from each of the embedded
    * Dart scripts.
    */
   static const String DART_ERRORS_INPUT = 'DART_ERRORS';
 
   /**
-   * The name of the [HTML_DOCUMENT_ERRORS] input.
-   */
-  static const String DOCUMENT_ERRORS_INPUT = 'DOCUMENT_ERRORS';
-
-  /**
    * The task descriptor describing this kind of task.
    */
   static final TaskDescriptor DESCRIPTOR = new TaskDescriptor('HtmlErrorsTask',
       createTask, buildInputs, <ResultDescriptor>[HTML_ERRORS]);
 
   HtmlErrorsTask(InternalAnalysisContext context, AnalysisTarget target)
       : super(context, target);
 
   @override
   TaskDescriptor get descriptor => DESCRIPTOR;
 
   @override
   void internalPerform() {
+    EnginePlugin enginePlugin = AnalysisEngine.instance.enginePlugin;
     //
     // Prepare inputs.
     //
     List<List<AnalysisError>> dartErrors = getRequiredInput(DART_ERRORS_INPUT);
-    List<AnalysisError> documentErrors =
-        getRequiredInput(DOCUMENT_ERRORS_INPUT);
+    List<List<AnalysisError>> htmlErrors = <List<AnalysisError>>[];
+    for (ResultDescriptor result in enginePlugin.htmlErrors) {
+      String inputName = result.name + '_input';

[Brian Wilkerson, 2015/09/14 18:55:35]

'_input' should be a constant

+      htmlErrors.add(getRequiredInput(inputName));
+    }
     //
     // Compute the error list.
     //
-    List<AnalysisError> errors = <AnalysisError>[];
-    errors.addAll(documentErrors);
-    for (List<AnalysisError> scriptErrors in dartErrors) {
-      errors.addAll(scriptErrors);
-    }
+    List<List<AnalysisError>> errorLists = <List<AnalysisError>>[];
+    errorLists.addAll(dartErrors);
+    errorLists.addAll(htmlErrors);
     //
     // Record outputs.
     //
-    outputs[HTML_ERRORS] = removeDuplicateErrors(errors);
+    outputs[HTML_ERRORS] = AnalysisError.mergeLists(errorLists);
   }
 
   /**
    * Return a map from the names of the inputs of this kind of task to the task
    * input descriptors describing those inputs for a task with the
    * given [target].
    */
   static Map<String, TaskInput> buildInputs(Source target) {
-    return <String, TaskInput>{
-      DOCUMENT_ERRORS_INPUT: HTML_DOCUMENT_ERRORS.of(target),
+    EnginePlugin enginePlugin = AnalysisEngine.instance.enginePlugin;
+    Map<String, TaskInput> inputs = <String, TaskInput>{
       DART_ERRORS_INPUT: DART_SCRIPTS.of(target).toListOf(DART_ERRORS)
     };
+    for (ResultDescriptor result in enginePlugin.htmlErrors) {
+      String inputName = result.name + '_input';
+      inputs[inputName] = result.of(target);
+    }
+    return inputs;
   }
 
   /**
    * Create an [HtmlErrorsTask] based on the given [target] in the given
    * [context].
    */
   static HtmlErrorsTask createTask(
       AnalysisContext context, AnalysisTarget target) {
     return new HtmlErrorsTask(context, target);
   }
@@ skipping 107 matching lines @@
    * The content of the fragment.
    */
   final String content;
 
   /**
    * Initialize a newly created script fragment to have the given [offset] and
    * [content].
    */
   ScriptFragment(this.offset, this.line, this.column, this.content);
 }