Issue 13407003: Third codegen test passing for simulated MIPS.

Issue 13407003: Third codegen test passing for simulated MIPS. (Closed)

Created:
7 years, 8 months ago by zra

Modified:
7 years, 8 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Third codegen test passing for simulated MIPS. Committed: https://code.google.com/p/dart/source/detail?r=20794

Patch Set 3 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+445 lines, -66 lines)			Patch
M	runtime/vm/assembler_mips.h	View	1 2	7 chunks	+15 lines, -28 lines	0 comments	Download
M	runtime/vm/assembler_mips.cc	View	1 2	3 chunks	+19 lines, -0 lines	0 comments	Download
M	runtime/vm/code_generator_test.cc	View	1 2	2 chunks	+0 lines, -7 lines	0 comments	Download
M	runtime/vm/code_patcher_mips.cc	View	1 2	3 chunks	+5 lines, -3 lines	0 comments	Download
M	runtime/vm/constants_mips.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View	1 2	2 chunks	+24 lines, -2 lines	0 comments	Download
M	runtime/vm/instructions_mips.cc	View	1 2	1 chunk	+5 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1 2	1 chunk	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/runtime_entry_mips.cc	View	1 2	1 chunk	+32 lines, -1 line	0 comments	Download
M	runtime/vm/simulator_mips.h	View	1 2	5 chunks	+23 lines, -0 lines	0 comments	Download
M	runtime/vm/simulator_mips.cc	View	1 2	6 chunks	+206 lines, -10 lines	0 comments	Download
M	runtime/vm/stack_frame_mips.cc	View	1 2	2 chunks	+12 lines, -9 lines	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View	1 2	3 chunks	+98 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zra

This is slightly out of order from what you did with ARM, but since the ...

7 years, 8 months ago (2013-04-02 00:13:14 UTC) #1

regis

LGTM! https://codereview.chromium.org/13407003/diff/11001/runtime/vm/assembler_mips.h File runtime/vm/assembler_mips.h (right): https://codereview.chromium.org/13407003/diff/11001/runtime/vm/assembler_mips.h#newcode530 runtime/vm/assembler_mips.h:530: void BranchPatchable(const ExternalLabel* label) { If there is ...

7 years, 8 months ago (2013-04-02 16:12:14 UTC) #2

zra

Thanks! https://codereview.chromium.org/13407003/diff/11001/runtime/vm/assembler_mips.h File runtime/vm/assembler_mips.h (right): https://codereview.chromium.org/13407003/diff/11001/runtime/vm/assembler_mips.h#newcode530 runtime/vm/assembler_mips.h:530: void BranchPatchable(const ExternalLabel* label) { On 2013/04/02 16:12:14, ...

7 years, 8 months ago (2013-04-02 16:40:02 UTC) #3

zra

7 years, 8 months ago (2013-04-02 16:40:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r20794 (presubmit successful).

Expand Messages | Collapse Messages