Third codegen test passing for simulated MIPS.

runtime/vm/assembler_mips.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_ASSEMBLER_MIPS_H_
 #define VM_ASSEMBLER_MIPS_H_
 
 #ifndef VM_ASSEMBLER_H_
 #error Do not include assembler_mips.h directly; use assembler.h instead.
 #endif
 
 #include "platform/assert.h"
+#include "platform/utils.h"
 #include "vm/constants_mips.h"
+#include "vm/simulator.h"
 
 // References to documentation in this file refer to:
 // "MIPS® Architecture For Programmers Volume I-A:
 //   Introduction to the MIPS32® Architecture" in short "VolI-A"
 // and
 // "MIPS® Architecture For Programmers Volume II-A:
 //   The MIPS32® Instruction Set" in short "VolII-A"
 namespace dart {
 
+// Forward declarations.
+class RuntimeEntry;
+
 class Immediate : public ValueObject {
  public:
   explicit Immediate(int32_t value) : value_(value) { }
 
   Immediate(const Immediate& other) : ValueObject(), value_(other.value_) { }
   Immediate& operator=(const Immediate& other) {
     value_ = other.value_;
     return *this;
   }
 
@@ skipping 130 matching lines @@
   }
 
   // Set up a stub frame so that the stack traversal code can easily identify
   // a stub frame.
   void EnterStubFrame();
   void LeaveStubFrame();
 
   // Instruction pattern from entrypoint is used in dart frame prologs
   // to set up the frame and save a PC which can be used to figure out the
   // RawInstruction object corresponding to the code running in the frame.
-  static const intptr_t kOffsetOfSavedPCfromEntrypoint = -1;  // UNIMPLEMENTED.
+  // See EnterDartFrame. There are 6 instructions before we know the PC.
+  static const intptr_t kOffsetOfSavedPCfromEntrypoint = 6 * Instr::kInstrSize;
 
   // Inlined allocation of an instance of class 'cls', code has no runtime
   // calls. Jump to 'failure' if the instance cannot be allocated here.
   // Allocated instance is returned in 'instance_reg'.
   // Only the tags field of the object is initialized.
   void TryAllocate(const Class& cls,
                    Label* failure,
                    bool near_jump,
                    Register instance_reg) {
     UNIMPLEMENTED();
@@ skipping 314 matching lines @@
     EmitLoadStore(SW, rt, addr);
   }
 
   void xor_(Register rd, Register rs, Register rt) {
     EmitRType(SPECIAL, rs, rt, rd, 0, XOR);
   }
 
   // Macros in alphabetical order.
 
   void Branch(const ExternalLabel* label) {
-    // Doesn't need to be patchable, so use the delay slot.
-    if (Utils::IsInt(16, label->address())) {
-      jr(TMP);
-      delay_slot()->addiu(TMP, ZR, Immediate(label->address()));
-    } else {
-      const uint16_t low = Utils::Low16Bits(label->address());
-      const uint16_t high = Utils::High16Bits(label->address());
-      lui(TMP, Immediate(high));
-      jr(TMP);
-      delay_slot()->ori(TMP, TMP, Immediate(low));
-    }
+    LoadImmediate(TMP, label->address());
+    jr(TMP);
   }
 
   void BranchLink(const ExternalLabel* label) {
-    // Doesn't need to be patchable, so use the delay slot.
-    if (Utils::IsInt(16, label->address())) {
-      jalr(TMP);
-      delay_slot()->addiu(TMP, ZR, Immediate(label->address()));
-    } else {
-      const uint16_t low = Utils::Low16Bits(label->address());
-      const uint16_t high = Utils::High16Bits(label->address());
-      lui(TMP, Immediate(high));
-      jalr(TMP);
-      delay_slot()->ori(TMP, TMP, Immediate(low));
-    }
+    LoadImmediate(TMP, label->address());
+    jalr(TMP);
   }
 
   void BranchLinkPatchable(const ExternalLabel* label) {
     const int32_t offset =
         Array::data_offset() + 4*AddExternalLabel(label) - kHeapObjectTag;
     LoadWordFromPoolOffset(TMP, offset);
     jalr(TMP);
   }
 
-  void BranchPatchable(const ExternalLabel* label) {
-    LoadImmediate(TMP, label->address());
-    jr(TMP);
-  }
-
   // If the signed value in rs is less than value, rd is 1, and 0 otherwise.
   void LessThanSImmediate(Register rd, Register rs, int32_t value) {
     LoadImmediate(TMP, value);
     slt(rd, rs, TMP);
   }
 
   // If the unsigned value in rs is less than value, rd is 1, and 0 otherwise.
   void LessThanUImmediate(Register rd, Register rs, uint32_t value) {
     LoadImmediate(TMP, value);
     sltu(rd, rs, TMP);
@@ skipping 32 matching lines @@
   }
 
   void SmiTag(Register reg) {
     sll(reg, reg, kSmiTagSize);
   }
 
   void SmiUntag(Register reg) {
     sra(reg, reg, kSmiTagSize);
   }
 
+  void ReserveAlignedFrameSpace(intptr_t frame_space);
+
   void LoadWordFromPoolOffset(Register rd, int32_t offset);
   void LoadObject(Register rd, const Object& object);
   void PushObject(const Object& object);
 
   // Sets register rd to zero if the object is equal to register rn,
   // set to non-zero otherwise.
   void CompareObject(Register rd, Register rn, const Object& object);
 
+  void CallRuntime(const RuntimeEntry& entry);
+
   // Set up a Dart frame on entry with a frame pointer and PC information to
   // enable easy access to the RawInstruction object of code corresponding
   // to this frame.
   void EnterDartFrame(intptr_t frame_size);
   void LeaveDartFrame();
 
  private:
   AssemblerBuffer buffer_;
   GrowableObjectArray& object_pool_;  // Objects and patchable jump targets.
   int prologue_offset_;
@@ skipping 113 matching lines @@
     delay_slot_available_ = true;
   }
 
   DISALLOW_ALLOCATION();
   DISALLOW_COPY_AND_ASSIGN(Assembler);
 };
 
 }  // namespace dart
 
 #endif  // VM_ASSEMBLER_MIPS_H_