Issue 13406004: - Remember objects (not addresses) in the old generation containing new pointers.

Issue 13406004: - Remember objects (not addresses) in the old generation containing new pointers. (Closed)

Created:
7 years, 8 months ago by Ivan Posva

Modified:
7 years, 8 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Remember objects (not addresses) in the old generation containing new pointers. Committed: https://code.google.com/p/dart/source/detail?r=20828

Patch Set 1 #

Total comments: 3

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -69 lines)			Patch
M	runtime/vm/assembler_ia32.cc	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	runtime/vm/assembler_test.cc	View	2 chunks	+7 lines, -14 lines	0 comments	Download
M	runtime/vm/assembler_x64.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/gc_marker.cc	View	6 chunks	+11 lines, -7 lines	0 comments	Download
M	runtime/vm/object.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/object.cc	View	2 chunks	+10 lines, -4 lines	3 comments	Download
M	runtime/vm/scavenger.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	runtime/vm/scavenger.cc	View	9 chunks	+22 lines, -37 lines	0 comments	Download
M	runtime/vm/store_buffer.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://codereview.chromium.org/13406004/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/13406004/diff/1/runtime/vm/object.cc#newcode1215 runtime/vm/object.cc:1215: // Remembered this object. There is not need ...

7 years, 8 months ago (2013-04-02 20:20:21 UTC) #2

Ivan Posva

Committed patchset #1 manually as r20828 (presubmit successful).

7 years, 8 months ago (2013-04-02 22:45:25 UTC) #3

Ivan Posva

7 years, 8 months ago (2013-04-02 23:23:10 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/13406004/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/13406004/diff/1/runtime/vm/object.cc#newcode1215
runtime/vm/object.cc:1215: // Remembered this object. There is not need to
continue searching.
On 2013/04/02 20:20:22, siva wrote:
> no need ...

Done.

https://codereview.chromium.org/13406004/diff/1/runtime/vm/object.cc#newcode1215
runtime/vm/object.cc:1215: // Remembered this object. There is not need to
continue searching.
On 2013/04/02 20:20:22, siva wrote:
> no need ...

Done.

Expand Messages | Collapse Messages