Issue 133893007: Rename internal library dart:_collection-dev to dart:_internal.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+261 lines, -2341 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	pkg/analyzer/test/generated/resolver_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/dartutils.h	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/dartutils.cc	View	1 2 3 4 5	2 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download
D	runtime/lib/collection_dev_patch.dart	View		1 chunk	+0 lines, -3 lines	0 comments	Download
D	runtime/lib/collection_dev_sources.gypi	View		1 chunk	+0 lines, -14 lines	0 comments	Download
M	runtime/lib/errors_patch.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/lib/function_patch.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	runtime/lib/internal_patch.dart	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	runtime/lib/internal_sources.gypi	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/lib/invocation_mirror_patch.dart	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/lib/mirrors_patch.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/lib/object_patch.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/lib/typed_data.dart	View	1 2 3 4 5	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/benchmark_test.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/bootstrap.h	View	1 2 3 4 5	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/bootstrap.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/isolate_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.h	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.cc	View	1 2 3 4 5	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/object_store.h	View	1 2 3 4 5	4 chunks	+6 lines, -8 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1 2 3 4 5	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/symbols.h	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/vm.gypi	View	1 2 3 4 5	19 chunks	+148 lines, -148 lines	0 comments	Download
M	samples/third_party/pop-pop-win/app_package/game_app.dart.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	samples/third_party/pop-pop-win/app_package/game_app.dart.precompiled.js	View		1 chunk	+1 line, -1 line	0 comments	Download
D	sdk/lib/_collection_dev/collection_dev.dart	View		1 chunk	+0 lines, -18 lines	0 comments	Download
D	sdk/lib/_collection_dev/collection_dev_sources.gypi	View		1 chunk	+0 lines, -17 lines	0 comments	Download
D	sdk/lib/_collection_dev/iterable.dart	View		1 chunk	+0 lines, -1167 lines	0 comments	Download
D	sdk/lib/_collection_dev/list.dart	View		1 chunk	+0 lines, -307 lines	0 comments	Download
D	sdk/lib/_collection_dev/lists.dart	View		1 chunk	+0 lines, -99 lines	0 comments	Download
D	sdk/lib/_collection_dev/print.dart	View		1 chunk	+0 lines, -17 lines	0 comments	Download
D	sdk/lib/_collection_dev/sort.dart	View		1 chunk	+0 lines, -344 lines	0 comments	Download
D	sdk/lib/_collection_dev/symbol.dart	View		1 chunk	+0 lines, -77 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/compiler.dart	View	1 2 3 4	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
D	sdk/lib/_internal/lib/collection_dev_patch.dart	View		1 chunk	+0 lines, -14 lines	0 comments	Download
M	sdk/lib/_internal/lib/core_patch.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/lib/interceptors.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A +	sdk/lib/_internal/lib/internal_patch.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/lib/js_helper.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/lib/js_mirrors.dart	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/libraries.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/async/async.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/collection/collection.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/core/core.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/core/symbol.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	sdk/lib/internal/internal.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A +	sdk/lib/internal/internal_sources.gypi	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A +	sdk/lib/internal/iterable.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A +	sdk/lib/internal/list.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A +	sdk/lib/internal/lists.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A +	sdk/lib/internal/print.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A +	sdk/lib/internal/sort.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A +	sdk/lib/internal/symbol.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/io/io.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/svg/dart2js/svg_dart2js.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/svg/dartium/svg_dartium.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/typed_data/dart2js/typed_data_dart2js.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/typed_data/typed_data.dart	View	1 2 3 4 5	2 chunks	+0 lines, -3 lines	0 comments	Download
M	sdk/lib/web_audio/dart2js/web_audio_dart2js.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/web_audio/dartium/web_audio_dartium.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/web_gl/dart2js/web_gl_dart2js.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/web_gl/dartium/web_gl_dartium.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/web_sql/dart2js/web_sql_dart2js.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/web_sql/dartium/web_sql_dartium.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/import_private_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/create_sdk.py	View	1 2 3 4 5	2 chunks	+3 lines, -3 lines	0 comments	Download
M	tools/dom/templates/html/dart2js/html_dart2js.darttemplate	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/dart2js/svg_dart2js.darttemplate	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/dart2js/web_audio_dart2js.darttemplate	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/dart2js/web_gl_dart2js.darttemplate	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/dart2js/web_sql_dart2js.darttemplate	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/dartium/html_dartium.darttemplate	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/dartium/svg_dartium.darttemplate	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/dartium/web_audio_dartium.darttemplate	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/dartium/web_gl_dartium.darttemplate	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/dartium/web_sql_dartium.darttemplate	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

Still have a VM fingerprint that needs updating, and a dart2js hack for symbol constructor ...

6 years, 11 months ago (2014-01-14 13:57:48 UTC) #1

floitsch

LGTM after your fixes. https://codereview.chromium.org/133893007/diff/130001/runtime/bin/dartutils.cc File runtime/bin/dartutils.cc (right): https://codereview.chromium.org/133893007/diff/130001/runtime/bin/dartutils.cc#newcode29 runtime/bin/dartutils.cc:29: const char* DartUtils::kInternalLibURL = "dart:_internal"; ...

6 years, 11 months ago (2014-01-14 19:21:00 UTC) #2

Ivan Posva

https://codereview.chromium.org/133893007/diff/130001/runtime/bin/dartutils.h File runtime/bin/dartutils.h (right): https://codereview.chromium.org/133893007/diff/130001/runtime/bin/dartutils.h#newcode212 runtime/bin/dartutils.h:212: static const char* kInternalLibURL; On 2014/01/14 19:21:01, floitsch wrote: ...

6 years, 11 months ago (2014-01-14 23:35:32 UTC) #3

Lasse Reichstein Nielsen

Committed patchset #5 manually as r31823 (presubmit successful).

6 years, 11 months ago (2014-01-15 09:25:47 UTC) #4

Lasse Reichstein Nielsen

6 years, 11 months ago (2014-01-15 09:27:41 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/133893007/diff/130001/runtime/bin/dartutils.cc
File runtime/bin/dartutils.cc (right):

https://codereview.chromium.org/133893007/diff/130001/runtime/bin/dartutils.c...
runtime/bin/dartutils.cc:29: const char* DartUtils::kInternalLibURL =
"dart:_internal";
On 2014/01/14 19:21:01, floitsch wrote:
> The URLs were sorted.

Done.

https://codereview.chromium.org/133893007/diff/130001/runtime/bin/dartutils.h
File runtime/bin/dartutils.h (right):

https://codereview.chromium.org/133893007/diff/130001/runtime/bin/dartutils.h...
runtime/bin/dartutils.h:212: static const char* kInternalLibURL;
On 2014/01/14 23:35:32, Ivan Posva wrote:
> On 2014/01/14 19:21:01, floitsch wrote:
> > I believe the URLs were sorted in order.
> 
> Yes, please.

Done.

https://codereview.chromium.org/133893007/diff/130001/runtime/vm/bootstrap.h
File runtime/vm/bootstrap.h (right):

https://codereview.chromium.org/133893007/diff/130001/runtime/vm/bootstrap.h#...
runtime/vm/bootstrap.h:26: static const char* internal_source_paths_[];
On 2014/01/14 19:21:01, floitsch wrote:
> paths were sorted.

Done.

https://codereview.chromium.org/133893007/diff/130001/runtime/vm/bootstrap.h#...
runtime/vm/bootstrap.h:39: static const char* internal_patch_paths_[];
On 2014/01/14 19:21:01, floitsch wrote:
> ditto.

Done.

https://codereview.chromium.org/133893007/diff/130001/runtime/vm/object_store.h
File runtime/vm/object_store.h (right):

https://codereview.chromium.org/133893007/diff/130001/runtime/vm/object_store...
runtime/vm/object_store.h:276: RawLibrary* internal_library() const {
On 2014/01/14 23:35:32, Ivan Posva wrote:
> Sorted and it probably fits onto a single line now.

Done.

https://codereview.chromium.org/133893007/diff/130001/runtime/vm/object_store...
runtime/vm/object_store.h:295: case kInternal:
On 2014/01/14 23:35:32, Ivan Posva wrote:
> Sorted.

Done.

https://codereview.chromium.org/133893007/diff/130001/runtime/vm/object_store...
runtime/vm/object_store.h:468: RawLibrary* internal_library_;
On 2014/01/14 23:35:32, Ivan Posva wrote:
> sorted

Done.

https://codereview.chromium.org/133893007/diff/130001/runtime/vm/symbols.h
File runtime/vm/symbols.h (right):

https://codereview.chromium.org/133893007/diff/130001/runtime/vm/symbols.h#ne...
runtime/vm/symbols.h:276: V(DartInternal, "dart:_internal")                     
           \
On 2014/01/14 23:35:32, Ivan Posva wrote:
> On 2014/01/14 19:21:01, floitsch wrote:
> > Fix trailing "\". (missing spaces).
> 
> Sorted.

Done.

https://codereview.chromium.org/133893007/diff/130001/runtime/vm/vm.gypi
File runtime/vm/vm.gypi (right):

https://codereview.chromium.org/133893007/diff/130001/runtime/vm/vm.gypi#newc...
runtime/vm/vm.gypi:16: 'internal_cc_file': '<(gen_source_dir)/internal_gen.cc',
On 2014/01/14 23:35:32, Ivan Posva wrote:
> s4d

SOrted below convert. (Although looking up that abbreviation wasn't helpful, or
entirely SFW :).

https://codereview.chromium.org/133893007/diff/130001/runtime/vm/vm.gypi#newc...
runtime/vm/vm.gypi:94: 'generate_internal_cc_file#host',
On 2014/01/14 23:35:32, Ivan Posva wrote:
> ditto

Done.

https://codereview.chromium.org/133893007/diff/130001/runtime/vm/vm.gypi#newc...
runtime/vm/vm.gypi:125: '<(internal_cc_file)',
On 2014/01/14 23:35:32, Ivan Posva wrote:
> ditto

Done.

https://codereview.chromium.org/133893007/diff/130001/runtime/vm/vm.gypi#newc...
runtime/vm/vm.gypi:321: {
I sorted all the library and patch blocks. They needed it :).

https://codereview.chromium.org/133893007/diff/130001/sdk/lib/typed_data/type...
File sdk/lib/typed_data/typed_data.dart (right):

https://codereview.chromium.org/133893007/diff/130001/sdk/lib/typed_data/type...
sdk/lib/typed_data/typed_data.dart:8: import 'dart:_internal';
Used to get IterableMixinWorkaround in the patch file.
I'll move the import to the patch file instead of having it here.

https://codereview.chromium.org/133893007/diff/130001/sdk/lib/typed_data/type...
sdk/lib/typed_data/typed_data.dart:9: import 'dart:math' show Random;
Used for the signature of List.shuffle in the patch file. Moving this too.

https://codereview.chromium.org/133893007/diff/130001/tools/create_sdk.py
File tools/create_sdk.py (right):

https://codereview.chromium.org/133893007/diff/130001/tools/create_sdk.py#new...
tools/create_sdk.py:199: 'async', 'collection', '_internal', 'convert',
Moved to between 'crypto' and 'io'.
And changed to 'internal', this is a directory name, not a library name.

Expand Messages | Collapse Messages