Rename internal library dart:_collection-dev to dart:_internal.

runtime/vm/vm.gypi

 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 {
   'variables': {
     'gen_source_dir': '<(SHARED_INTERMEDIATE_DIR)',
     'libgen_in_cc_file': '../lib/libgen_in.cc',
     'builtin_in_cc_file': '../bin/builtin_in.cc',
     'async_cc_file': '<(gen_source_dir)/async_gen.cc',
     'async_patch_cc_file': '<(gen_source_dir)/async_patch_gen.cc',
     'corelib_cc_file': '<(gen_source_dir)/corelib_gen.cc',
     'corelib_patch_cc_file': '<(gen_source_dir)/corelib_patch_gen.cc',
     'collection_cc_file': '<(gen_source_dir)/collection_gen.cc',
     'collection_patch_cc_file': '<(gen_source_dir)/collection_patch_gen.cc',
-    'collection_dev_cc_file': '<(gen_source_dir)/collection_dev_gen.cc',
-    'collection_dev_patch_cc_file': '<(gen_source_dir)/collection_dev_patch_gen.cc',
+    'internal_cc_file': '<(gen_source_dir)/internal_gen.cc',

[Ivan Posva, 2014/01/14 23:35:32]

s4d

[Lasse Reichstein Nielsen, 2014/01/15 09:27:42]

SOrted below convert. (Although looking up that abbreviation wasn't helpful, or
entirely SFW :).

+    'internal_patch_cc_file': '<(gen_source_dir)/internal_patch_gen.cc',
     'convert_cc_file': '<(gen_source_dir)/convert_gen.cc',
     'convert_patch_cc_file': '<(gen_source_dir)/convert_patch_gen.cc',
     'math_cc_file': '<(gen_source_dir)/math_gen.cc',
     'math_patch_cc_file': '<(gen_source_dir)/math_patch_gen.cc',
     'mirrors_cc_file': '<(gen_source_dir)/mirrors_gen.cc',
     'mirrors_patch_cc_file': '<(gen_source_dir)/mirrors_patch_gen.cc',
     'isolate_cc_file': '<(gen_source_dir)/isolate_gen.cc',
     'isolate_patch_cc_file': '<(gen_source_dir)/isolate_patch_gen.cc',
     'typed_data_cc_file': '<(gen_source_dir)/typed_data_gen.cc',
     'typed_data_patch_cc_file': '<(gen_source_dir)/typed_data_patch_gen.cc',
@@ skipping 56 matching lines @@
       'target_name': 'libdart_lib_withcore',
       'type': 'static_library',
       'toolsets':['host', 'target'],
       'dependencies': [
         'generate_async_cc_file#host',
         'generate_async_patch_cc_file#host',
         'generate_corelib_cc_file#host',
         'generate_corelib_patch_cc_file#host',
         'generate_collection_cc_file#host',
         'generate_collection_patch_cc_file#host',
-        'generate_collection_dev_cc_file#host',
-        'generate_collection_dev_patch_cc_file#host',
+        'generate_internal_cc_file#host',

[Ivan Posva, 2014/01/14 23:35:32]

ditto

[Lasse Reichstein Nielsen, 2014/01/15 09:27:42]

Done.

+        'generate_internal_patch_cc_file#host',
         'generate_convert_cc_file#host',
         'generate_convert_patch_cc_file#host',
         'generate_math_cc_file#host',
         'generate_math_patch_cc_file#host',
         'generate_isolate_cc_file#host',
         'generate_isolate_patch_cc_file#host',
         'generate_mirrors_cc_file#host',
         'generate_mirrors_patch_cc_file#host',
         'generate_typed_data_cc_file#host',
         'generate_typed_data_patch_cc_file#host',
       ],
       'includes': [
         '../lib/async_sources.gypi',
         '../lib/collection_sources.gypi',
         '../lib/corelib_sources.gypi',
         '../lib/isolate_sources.gypi',
         '../lib/math_sources.gypi',
         '../lib/mirrors_sources.gypi',
         '../lib/typed_data_sources.gypi',
       ],
       'sources': [
         'bootstrap.cc',
         # Include generated source files.
         '<(async_cc_file)',
         '<(async_patch_cc_file)',
         '<(corelib_cc_file)',
         '<(corelib_patch_cc_file)',
         '<(collection_cc_file)',
         '<(collection_patch_cc_file)',
-        '<(collection_dev_cc_file)',
-        '<(collection_dev_patch_cc_file)',
+        '<(internal_cc_file)',

[Ivan Posva, 2014/01/14 23:35:32]

ditto

[Lasse Reichstein Nielsen, 2014/01/15 09:27:42]

Done.

+        '<(internal_patch_cc_file)',
         '<(convert_cc_file)',
         '<(convert_patch_cc_file)',
         '<(math_cc_file)',
         '<(math_patch_cc_file)',
         '<(isolate_cc_file)',
         '<(isolate_patch_cc_file)',
         '<(mirrors_cc_file)',
         '<(mirrors_patch_cc_file)',
         '<(typed_data_cc_file)',
         '<(typed_data_patch_cc_file)',
@@ skipping 174 matching lines @@
             '--input_cc', '<(libgen_in_cc_file)',
             '--include', 'vm/bootstrap.h',
             '--var_name', 'dart::Bootstrap::collection_source_paths_',
             '--library_name', 'dart:collection',
             '<@(_sources)',
           ],
           'message': 'Generating ''<(collection_cc_file)'' file.'
         },
       ]
     },
     {

[Ivan Posva, 2014/01/14 23:35:32]

These blocks are also sorted.

[Lasse Reichstein Nielsen, 2014/01/15 09:27:42]

I sorted all the library and patch blocks. They needed it :).

-      'target_name': 'generate_collection_dev_patch_cc_file',
+      'target_name': 'generate_internal_patch_cc_file',
       'type': 'none',
       'toolsets':['host'],
       'includes': [
         # Load the runtime implementation sources.
-        '../lib/collection_dev_sources.gypi',
+        '../lib/internal_sources.gypi',
       ],
       'sources/': [
         # Exclude all .[cc|h] files.
         # This is only here for reference. Excludes happen after
         # variable expansion, so the script has to do its own
         # exclude processing of the sources being passed.
         ['exclude', '\\.cc|h$'],
       ],
       'actions': [
         {
-          'action_name': 'generate_collection_dev_patch_cc',
+          'action_name': 'generate_internal_patch_cc',
           'inputs': [
             '../tools/gen_library_src_paths.py',
             '<(libgen_in_cc_file)',
             '<@(_sources)',
           ],
           'outputs': [
-            '<(collection_dev_patch_cc_file)',
+            '<(internal_patch_cc_file)',
           ],
           'action': [
             'python',
             'tools/gen_library_src_paths.py',
-            '--output', '<(collection_dev_patch_cc_file)',
+            '--output', '<(internal_patch_cc_file)',
             '--input_cc', '<(libgen_in_cc_file)',
             '--include', 'vm/bootstrap.h',
-            '--var_name', 'dart::Bootstrap::collection_dev_patch_paths_',
-            '--library_name', 'dart:_collection-dev',
+            '--var_name', 'dart::Bootstrap::internal_patch_paths_',
+            '--library_name', 'dart:_internal',
             '<@(_sources)',
           ],
-          'message': 'Generating ''<(collection_dev_patch_cc_file)'' file.'
+          'message': 'Generating ''<(internal_patch_cc_file)'' file.'
         },
       ]
     },
     {
-      'target_name': 'generate_collection_dev_cc_file',
+      'target_name': 'generate_internal_cc_file',
       'type': 'none',
       'toolsets':['host'],
       'includes': [
-        # Load the shared collection_dev library sources.
-        '../../sdk/lib/_collection_dev/collection_dev_sources.gypi',
+        # Load the shared internal library sources.
+        '../../sdk/lib/internal/internal_sources.gypi',
       ],
       'sources/': [
         # Exclude all .[cc|h] files.
         # This is only here for reference. Excludes happen after
         # variable expansion, so the script has to do its own
         # exclude processing of the sources being passed.
         ['exclude', '\\.cc|h$'],
       ],
       'actions': [
         {
-          'action_name': 'generate_collection_dev_cc',
+          'action_name': 'generate_internal_cc',
           'inputs': [
             '../tools/gen_library_src_paths.py',
             '<(libgen_in_cc_file)',
             '<@(_sources)',
           ],
           'outputs': [
-            '<(collection_dev_cc_file)',
+            '<(internal_cc_file)',
           ],
           'action': [
             'python',
             'tools/gen_library_src_paths.py',
-            '--output', '<(collection_dev_cc_file)',
+            '--output', '<(internal_cc_file)',
             '--input_cc', '<(libgen_in_cc_file)',
             '--include', 'vm/bootstrap.h',
-            '--var_name', 'dart::Bootstrap::collection_dev_source_paths_',
-            '--library_name', 'dart:_collection-dev',
+            '--var_name', 'dart::Bootstrap::internal_source_paths_',
+            '--library_name', 'dart:_internal',
             '<@(_sources)',
           ],
-          'message': 'Generating ''<(collection_dev_cc_file)'' file.'
+          'message': 'Generating ''<(internal_cc_file)'' file.'
         },
       ]
     },
     {
       'target_name': 'generate_convert_cc_file',
       'type': 'none',
       'toolsets':['host'],
       'includes': [
         # Load the shared convert library sources.
         '../../sdk/lib/convert/convert_sources.gypi',
@@ skipping 493 matching lines @@
             '--include', 'INTENTIONALLY_LEFT_BLANK',
             '--var_name', 'INTENTIONALLY_LEFT_BLANK_TOO',
             '<(snapshot_test_dart_file)',
           ],
           'message': 'Generating ''<(snapshot_test_dat_file)'' file.'
         },
       ]
     },
   ]
 }