Makes the $ variable local to the dart2js enclosing function.

Makes the $ variable local to the deferred enclosing function.

This fixes https://github.com/dart-lang/sdk/issues/24328
BUG=
R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/dc6b09a6d70095ff65a8bbd850de4c6f5bfbbb42

[sigurdm, 2015-09-14 12:06:04]

Patchset #1 (id:1) has been deleted

[sigurdm, 2015-09-14 12:07:16]

sigurdm@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2015-09-14 13:25:38]

LGTM.
I wonder what the reason was to use arguments[1].

https://codereview.chromium.org/1337923006/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart (right):

https://codereview.chromium.org/1337923006/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart:1994: """function (#,
\$) {
namer.staticStateHolder

[sigurdm, 2015-09-14 13:34:57]

Yes - I cannot see any valid reason for it.

https://codereview.chromium.org/1337923006/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart (right):

https://codereview.chromium.org/1337923006/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart:1994: """function (#,
\$) {
On 2015/09/14 13:25:38, floitsch wrote:
> namer.staticStateHolder

Done.

[sigurdm, 2015-09-14 13:36:08]

Committed patchset #2 (id:40001) manually as
dc6b09a6d70095ff65a8bbd850de4c6f5bfbbb42 (presubmit successful).

[sigurdm, 2015-09-14 13:49:45]

Seems it was done here:
https://codereview.chromium.org//646083002 not sure I understand why yet. Will
investigate more tomorrow.