Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1010)

Issue 646083002: dart2js: Fast fix for deferred globals. (Closed)

Created:
6 years, 2 months ago by floitsch
Modified:
5 years, 7 months ago
Reviewers:
Chris Bracken, sigurdm
CC:
reviews_dartlang.org, sra1
Visibility:
Public.

Description

dart2js: Fast fix for deferred globals. The fix is not perfect: it uses "arguments[1]" to avoid coming up with a fresh name. Global variables are still allocated in the main-unit. If they are initialized with a constant value, they drag in that value into the main unit. (see http://dartbug.com/21301). That bug should, however, affect very few users. BUG= http://dartbug.com/21293 R=cbracken@google.com Committed: https://code.google.com/p/dart/source/detail?r=41056

Patch Set 1 #

Patch Set 2 : More comments. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -88 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/emitter.dart View 1 2 chunks +12 lines, -1 line 1 comment Download
M tests/compiler/dart2js/dart2js.status View 1 chunk +2 lines, -0 lines 0 comments Download
A + tests/compiler/dart2js/deferred_dont_inline_deferred_globals_test.dart View 2 chunks +8 lines, -87 lines 0 comments Download
A tests/language/deferred_global_lib.dart View 1 chunk +24 lines, -0 lines 0 comments Download
A tests/language/deferred_global_test.dart View 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
floitsch
6 years, 2 months ago (2014-10-10 22:10:22 UTC) #2
floitsch
https://codereview.chromium.org/646083002/diff/70001/sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/emitter.dart File sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/emitter.dart (right): https://codereview.chromium.org/646083002/diff/70001/sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/emitter.dart#newcode1839 sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/emitter.dart:1839: ..write('var ${namer.currentIsolate}$_=$_$isolatePropertiesName$N') This is, where we set the namer.currentIsolate ...
6 years, 2 months ago (2014-10-10 22:12:21 UTC) #3
Chris Bracken
lgtm - thanks.
6 years, 2 months ago (2014-10-10 23:34:47 UTC) #4
floitsch
6 years, 2 months ago (2014-10-10 23:53:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:70001) manually as 41056 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698