Issue 1336843003: Avoid dart:io dependency in try

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1336843003: Avoid dart:io dependency in try (Closed)

Created:
5 years, 3 months ago by Johnni Winther

Modified:
5 years, 3 months ago

Reviewers:
sigurdm

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Avoid dart:io dependency in try BUG= Committed: https://github.com/dart-lang/sdk/commit/f850f312e3f166d54735d54060660c4daccb9948

Patch Set 1 #

Total comments: 1

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -34 lines)			Patch
M	tests/compiler/dart2js/compiler_helper.dart	View	3 chunks	+1 line, -31 lines	1 comment	Download
M	tests/compiler/dart2js/mock_compiler.dart	View	1 chunk	+28 lines, -0 lines	0 comments	Download
M	tests/try/poi/compiler_test_case.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/try/poi/diff_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/try/poi/forget_element_assertion.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Johnni Winther

TBR https://codereview.chromium.org/1336843003/diff/1/tests/compiler/dart2js/compiler_helper.dart File tests/compiler/dart2js/compiler_helper.dart (left): https://codereview.chromium.org/1336843003/diff/1/tests/compiler/dart2js/compiler_helper.dart#oldcode135 tests/compiler/dart2js/compiler_helper.dart:135: // TODO(herhut): Disallow warnings and errors during compilation ...

5 years, 3 months ago (2015-09-11 14:02:55 UTC) #2

Johnni Winther

Committed patchset #1 (id:1) manually as f850f312e3f166d54735d54060660c4daccb9948 (presubmit successful).

5 years, 3 months ago (2015-09-11 14:03:27 UTC) #3

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages