Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: tests/compiler/dart2js/compiler_helper.dart

Issue 1336843003: Avoid dart:io dependency in try (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/compiler/dart2js/mock_compiler.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/compiler_helper.dart
diff --git a/tests/compiler/dart2js/compiler_helper.dart b/tests/compiler/dart2js/compiler_helper.dart
index 2452af73198cdf503674724575b4d7c8a687ab37..d3ac2acb2de72441686b3b7ef5518421fd32c98b 100644
--- a/tests/compiler/dart2js/compiler_helper.dart
+++ b/tests/compiler/dart2js/compiler_helper.dart
@@ -7,8 +7,6 @@ library compiler_helper;
import 'dart:async';
import "package:expect/expect.dart";
-import 'package:compiler/compiler.dart' as api;
-
import 'package:compiler/src/elements/elements.dart'
as lego;
export 'package:compiler/src/elements/elements.dart';
@@ -40,7 +38,7 @@ export 'package:compiler/src/tree/tree.dart';
import 'mock_compiler.dart';
export 'mock_compiler.dart';
-import 'memory_compiler.dart';
+import 'memory_compiler.dart' hide compilerFor;
import 'output_collector.dart';
export 'output_collector.dart';
@@ -132,34 +130,6 @@ Future<String> compile(String code,
}
}
-// TODO(herhut): Disallow warnings and errors during compilation by default.
Johnni Winther 2015/09/11 14:02:55 Moved to mock_compiler.dart
-MockCompiler compilerFor(String code, Uri uri,
- {bool analyzeAll: false,
- bool analyzeOnly: false,
- Map<String, String> coreSource,
- bool disableInlining: true,
- bool minify: false,
- bool trustTypeAnnotations: false,
- bool enableTypeAssertions: false,
- int expectedErrors,
- int expectedWarnings,
- api.CompilerOutputProvider outputProvider}) {
- MockCompiler compiler = new MockCompiler.internal(
- analyzeAll: analyzeAll,
- analyzeOnly: analyzeOnly,
- coreSource: coreSource,
- disableInlining: disableInlining,
- enableMinification: minify,
- trustTypeAnnotations: trustTypeAnnotations,
- enableTypeAssertions: enableTypeAssertions,
- expectedErrors: expectedErrors,
- expectedWarnings: expectedWarnings,
- outputProvider: outputProvider);
- compiler.registerSource(uri, code);
- compiler.diagnosticHandler = createHandler(compiler, code);
- return compiler;
-}
-
Future<String> compileAll(String code,
{Map<String, String> coreSource,
bool disableInlining: true,
« no previous file with comments | « no previous file | tests/compiler/dart2js/mock_compiler.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698