Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1335983004: Add ImportElement and ExportElement (Closed)

Created:
5 years, 3 months ago by Johnni Winther
Modified:
5 years, 3 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+824 lines, -396 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/constants/expressions.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/dart_backend/outputter.dart View 3 chunks +14 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 13 chunks +36 lines, -40 lines 0 comments Download
M pkg/compiler/lib/src/dump_info.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/elements/common.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 6 chunks +51 lines, -21 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 17 chunks +155 lines, -52 lines 0 comments Download
M pkg/compiler/lib/src/elements/names.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/visitor.dart View 2 chunks +12 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +3 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/library_loader.dart View 27 chunks +137 lines, -96 lines 0 comments Download
M pkg/compiler/lib/src/mirrors/dart2js_library_mirror.dart View 4 chunks +26 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/mirrors_used.dart View 5 chunks +9 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/serialization/element_serialization.dart View 5 chunks +91 lines, -20 lines 0 comments Download
M pkg/compiler/lib/src/serialization/keys.dart View 3 chunks +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 1 9 chunks +166 lines, -70 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/tree/unparser.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/array_tracing_mirror_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/reexport_handled_test.dart View 1 chunk +2 lines, -11 lines 0 comments Download
M tests/compiler/dart2js/related_types.dart View 1 chunk +17 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/serialization_test.dart View 6 chunks +60 lines, -15 lines 0 comments Download
M tests/compiler/dart2js/tag_mapping_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
Main changes in elements.dart and libary_loader.dart Implementations in modelx.dart and modelz.dart
5 years, 3 months ago (2015-09-14 13:17:45 UTC) #2
karlklose
LGTM. https://codereview.chromium.org/1335983004/diff/1/pkg/compiler/lib/src/elements/modelx.dart File pkg/compiler/lib/src/elements/modelx.dart (right): https://codereview.chromium.org/1335983004/diff/1/pkg/compiler/lib/src/elements/modelx.dart#newcode764 pkg/compiler/lib/src/elements/modelx.dart:764: class Importers { Could you think of a ...
5 years, 3 months ago (2015-09-15 06:35:56 UTC) #3
Johnni Winther
https://codereview.chromium.org/1335983004/diff/1/pkg/compiler/lib/src/elements/modelx.dart File pkg/compiler/lib/src/elements/modelx.dart (right): https://codereview.chromium.org/1335983004/diff/1/pkg/compiler/lib/src/elements/modelx.dart#newcode764 pkg/compiler/lib/src/elements/modelx.dart:764: class Importers { On 2015/09/15 06:35:55, karlklose wrote: > ...
5 years, 3 months ago (2015-09-15 07:50:07 UTC) #4
Johnni Winther
5 years, 3 months ago (2015-09-15 08:06:20 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
b98cd400550e100c8f63f48338a2d04c4fef4c68 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698