Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: pkg/compiler/lib/src/typechecker.dart

Issue 1335983004: Add ImportElement and ExportElement (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comments. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pkg/compiler/lib/src/tree/unparser.dart ('k') | pkg/compiler/lib/src/use_unused_api.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.typechecker; 5 library dart2js.typechecker;
6 6
7 import 'common/names.dart' show 7 import 'common/names.dart' show
8 Identifiers; 8 Identifiers;
9 import 'common/tasks.dart' show 9 import 'common/tasks.dart' show
10 CompilerTask; 10 CompilerTask;
(...skipping 720 matching lines...) Expand 10 before | Expand all | Expand 10 after
731 } 731 }
732 732
733 void checkPrivateAccess(Node node, Element element, String name) { 733 void checkPrivateAccess(Node node, Element element, String name) {
734 if (name != null && 734 if (name != null &&
735 Name.isPrivateName(name) && 735 Name.isPrivateName(name) &&
736 element.library != currentLibrary) { 736 element.library != currentLibrary) {
737 reportTypeWarning( 737 reportTypeWarning(
738 node, 738 node,
739 MessageKind.PRIVATE_ACCESS, 739 MessageKind.PRIVATE_ACCESS,
740 {'name': name, 740 {'name': name,
741 'libraryName': element.library.getLibraryOrScriptName()}); 741 'libraryName': element.library.libraryOrScriptName});
742 } 742 }
743 743
744 } 744 }
745 745
746 ElementAccess lookupMember(Node node, DartType receiverType, String name, 746 ElementAccess lookupMember(Node node, DartType receiverType, String name,
747 MemberKind memberKind, Element receiverElement, 747 MemberKind memberKind, Element receiverElement,
748 {bool lookupClassMember: false, 748 {bool lookupClassMember: false,
749 bool isHint: false}) { 749 bool isHint: false}) {
750 if (receiverType.treatAsDynamic) { 750 if (receiverType.treatAsDynamic) {
751 return const DynamicAccess(); 751 return const DynamicAccess();
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
825 if (!interface.element.isProxy && !analyzingInitializer) { 825 if (!interface.element.isProxy && !analyzingInitializer) {
826 bool foundPrivateMember = false; 826 bool foundPrivateMember = false;
827 if (memberName.isPrivate) { 827 if (memberName.isPrivate) {
828 void findPrivateMember(MemberSignature member) { 828 void findPrivateMember(MemberSignature member) {
829 if (memberName.isSimilarTo(member.name)) { 829 if (memberName.isSimilarTo(member.name)) {
830 PrivateName privateName = member.name; 830 PrivateName privateName = member.name;
831 reportMessage( 831 reportMessage(
832 node, 832 node,
833 MessageKind.PRIVATE_ACCESS, 833 MessageKind.PRIVATE_ACCESS,
834 {'name': name, 834 {'name': name,
835 'libraryName': privateName.library.getLibraryOrScriptName()}, 835 'libraryName': privateName.library.libraryOrScriptName},
836 isHint: isHint); 836 isHint: isHint);
837 foundPrivateMember = true; 837 foundPrivateMember = true;
838 } 838 }
839 } 839 }
840 // TODO(johnniwinther): Avoid computation of all class members. 840 // TODO(johnniwinther): Avoid computation of all class members.
841 MembersCreator.computeAllClassMembers(compiler, interface.element); 841 MembersCreator.computeAllClassMembers(compiler, interface.element);
842 if (lookupClassMember) { 842 if (lookupClassMember) {
843 interface.element.forEachClassMember(findPrivateMember); 843 interface.element.forEachClassMember(findPrivateMember);
844 } else { 844 } else {
845 interface.element.forEachInterfaceMember(findPrivateMember); 845 interface.element.forEachInterfaceMember(findPrivateMember);
(...skipping 1097 matching lines...) Expand 10 before | Expand all | Expand 10 after
1943 1943
1944 visitTypedef(Typedef node) { 1944 visitTypedef(Typedef node) {
1945 // Do not typecheck [Typedef] nodes. 1945 // Do not typecheck [Typedef] nodes.
1946 } 1946 }
1947 1947
1948 visitNode(Node node) { 1948 visitNode(Node node) {
1949 compiler.internalError(node, 1949 compiler.internalError(node,
1950 'Unexpected node ${node.getObjectDescription()} in the type checker.'); 1950 'Unexpected node ${node.getObjectDescription()} in the type checker.');
1951 } 1951 }
1952 } 1952 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/tree/unparser.dart ('k') | pkg/compiler/lib/src/use_unused_api.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698