Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13345002: Cleaned up OpenGLUI samples and added Blasteroids. (Closed)

Created:
7 years, 8 months ago by gram
Modified:
7 years, 6 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva, kustermann, ricow1, ahe
Visibility:
Public.

Description

Cleaned up OpenGLUI samples and added Blasteroids. Removed .hex files and replaced with binary files. These will get added in a separate non-reviewed CL to get around Rietveld limitation. Committed: https://code.google.com/p/dart/source/detail?r=20745

Patch Set 1 #

Patch Set 2 : #

Total comments: 20

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4339 lines, -4202 lines) Patch
M runtime/embedders/openglui/android/android_input_handler.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M runtime/embedders/openglui/android/android_sound_handler.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M runtime/embedders/openglui/android/main.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M runtime/embedders/openglui/common/gl.dart View 1 2 16 chunks +196 lines, -179 lines 0 comments Download
M runtime/embedders/openglui/common/image_cache.cc View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/embedders/openglui/common/vm_glue.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M runtime/embedders/openglui/common/vm_glue.cc View 1 2 2 chunks +9 lines, -5 lines 0 comments Download
M runtime/embedders/openglui/emulator/emulator_embedder.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/embedders/openglui/openglui_embedder.gypi View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
A samples/openglui/android-blasteroids/AndroidManifest.xml View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A samples/openglui/android-blasteroids/android.gyp View 1 2 1 chunk +90 lines, -0 lines 0 comments Download
A samples/openglui/android-blasteroids/build.xml View 1 2 1 chunk +96 lines, -0 lines 0 comments Download
A samples/openglui/android-blasteroids/custom_rules.xml View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
A samples/openglui/android-blasteroids/project.properties View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
A samples/openglui/android-blasteroids/res/values/strings.xml View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
A samples/openglui/android-blasteroids/res/values/styles.xml View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
A samples/openglui/android-blasteroids/src/com/google/dartndk/DummyActivity.java View 1 2 1 chunk +42 lines, -0 lines 0 comments Download
M + samples/openglui/android-canvas-tests/android.gyp View 1 2 3 chunks +1 line, -3 lines 0 comments Download
M + samples/openglui/android-canvas-tests/custom_rules.xml View 1 2 1 chunk +0 lines, -35 lines 0 comments Download
D samples/openglui/android-canvas-tests/ic_launcher.png-hdpi.hex View 1 2 1 chunk +0 lines, -514 lines 0 comments Download
D samples/openglui/android-canvas-tests/ic_launcher.png-ldpi.hex View 1 2 1 chunk +0 lines, -160 lines 0 comments Download
D samples/openglui/android-canvas-tests/ic_launcher.png-mdpi.hex View 1 2 1 chunk +0 lines, -254 lines 0 comments Download
D samples/openglui/android-canvas-tests/ic_launcher.png-xhdpi.hex View 1 2 1 chunk +0 lines, -848 lines 0 comments Download
A samples/openglui/android-webgl-raytrace/AndroidManifest.xml View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A samples/openglui/android-webgl-raytrace/android.gyp View 1 2 1 chunk +72 lines, -0 lines 0 comments Download
A samples/openglui/android-webgl-raytrace/build.xml View 1 2 1 chunk +96 lines, -0 lines 0 comments Download
A samples/openglui/android-webgl-raytrace/custom_rules.xml View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
A samples/openglui/android-webgl-raytrace/project.properties View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
A samples/openglui/android-webgl-raytrace/res/values/strings.xml View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
A samples/openglui/android-webgl-raytrace/res/values/styles.xml View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
A samples/openglui/android-webgl-raytrace/src/com/google/dartndk/DummyActivity.java View 1 2 1 chunk +42 lines, -0 lines 0 comments Download
D samples/openglui/android/AndroidManifest.xml View 1 2 1 chunk +0 lines, -32 lines 0 comments Download
D samples/openglui/android/android.gyp View 1 2 1 chunk +0 lines, -74 lines 0 comments Download
D samples/openglui/android/build.xml View 1 2 1 chunk +0 lines, -96 lines 0 comments Download
D samples/openglui/android/custom_rules.xml View 1 2 1 chunk +0 lines, -51 lines 0 comments Download
D samples/openglui/android/ic_launcher.png-hdpi.hex View 1 2 1 chunk +0 lines, -514 lines 0 comments Download
D samples/openglui/android/ic_launcher.png-ldpi.hex View 1 2 1 chunk +0 lines, -160 lines 0 comments Download
D samples/openglui/android/ic_launcher.png-mdpi.hex View 1 2 1 chunk +0 lines, -254 lines 0 comments Download
D samples/openglui/android/ic_launcher.png-xhdpi.hex View 1 2 1 chunk +0 lines, -848 lines 0 comments Download
D samples/openglui/android/project.properties View 1 2 1 chunk +0 lines, -21 lines 0 comments Download
D samples/openglui/android/res/values/strings.xml View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
D samples/openglui/android/res/values/styles.xml View 1 2 1 chunk +0 lines, -20 lines 0 comments Download
D samples/openglui/android/src/com/google/dartndk/DummyActivity.java View 1 2 1 chunk +0 lines, -42 lines 0 comments Download
M samples/openglui/emulator/emulator.gyp View 1 2 4 chunks +19 lines, -18 lines 0 comments Download
M samples/openglui/openglui.gyp View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M samples/openglui/pubspec.yaml View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A samples/openglui/src/blasteroids.dart View 1 2 1 chunk +3334 lines, -0 lines 0 comments Download
M samples/openglui/src/flashingbox.dart View 1 2 2 chunks +14 lines, -9 lines 0 comments Download
M samples/openglui/src/gl.dart View 1 2 1 chunk +18 lines, -17 lines 0 comments Download
M samples/openglui/src/openglui_canvas_tests.dart View 1 2 4 chunks +46 lines, -7 lines 0 comments Download
M samples/openglui/src/openglui_raytrace.dart View 1 2 2 chunks +1 line, -4 lines 0 comments Download
A samples/openglui/web/blasteroids.css View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
A samples/openglui/web/blasteroids.html View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
A samples/openglui/web/blasteroids_driver.dart View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M samples/openglui/web/flashingbox_driver.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M samples/openglui/web/gl_driver.dart View 1 2 1 chunk +2 lines, -10 lines 0 comments Download
M samples/openglui/web/openglui_canvas_tests_driver.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M samples/openglui/web/openglui_raytrace_driver.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
gram
7 years, 8 months ago (2013-03-29 21:05:12 UTC) #1
vsm
Nice! LGTM with comments... https://chromiumcodereview.appspot.com/13345002/diff/19001/samples/openglui/android-blasteroids/android.gyp File samples/openglui/android-blasteroids/android.gyp (right): https://chromiumcodereview.appspot.com/13345002/diff/19001/samples/openglui/android-blasteroids/android.gyp#newcode11 samples/openglui/android-blasteroids/android.gyp:11: 'target_name': 'android_sample', 'android_app'? https://chromiumcodereview.appspot.com/13345002/diff/19001/samples/openglui/src/blasteroids.dart File ...
7 years, 8 months ago (2013-04-01 14:00:17 UTC) #2
gram
Committed patchset #3 manually as r20745 (presubmit successful).
7 years, 8 months ago (2013-04-01 19:49:38 UTC) #3
ahe
7 years, 8 months ago (2013-04-02 10:04:28 UTC) #4
Message was sent while issue was closed. 
samples/openglui contains 8.1 MB when checked out.

Is this really needed? Could it have been a third_party gclient dependency?

Powered by Google App Engine
This is Rietveld 408576698