Issue 1331433003: Fix handling of shortcutting expressions and asserts in ExitDetector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1331433003: Fix handling of shortcutting expressions and asserts in ExitDetector. (Closed)

Created:
5 years, 3 months ago by Paul Berry

Modified:
5 years, 3 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix handling of shortcutting expressions and asserts in ExitDetector. Fixes #24293. Fixes #24294. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/5ea1238b560faf7b4572ed85edb95027c9473752

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+123 lines, -19 lines)			Patch
	M	pkg/analyzer/lib/src/generated/resolver.dart	View		4 chunks	+36 lines, -12 lines	0 comments	Download
	M	pkg/analyzer/test/generated/all_the_rest_test.dart	View		5 chunks	+87 lines, -7 lines	0 comments	Download

Total messages: 4 (1 generated)

Paul Berry

5 years, 3 months ago (2015-09-07 19:23:36 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5ea1238b560faf7b4572ed85edb95027c9473752 (presubmit successful).