Fix handling of shortcutting expressions and asserts in ExitDetector.

pkg/analyzer/test/generated/all_the_rest_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library engine.all_the_rest_test;
 
 import 'package:analyzer/file_system/physical_file_system.dart';
 import 'package:analyzer/src/generated/ast.dart' hide ConstantEvaluator;
 import 'package:analyzer/src/generated/constant.dart';
 import 'package:analyzer/src/generated/element.dart';
@@ skipping 7333 matching lines @@
 
   void test_asExpression_throw() {
     _assertTrue("throw '' as Object;");
   }
 
   void test_assertStatement() {
     _assertFalse("assert(a);");
   }
 
   void test_assertStatement_throw() {
-    _assertTrue("assert((throw 0));");
+    _assertFalse("assert((throw 0));");
   }
 
   void test_assignmentExpression() {
     _assertFalse("v = 1;");
   }
 
   void test_assignmentExpression_lhs_throw() {
     _assertTrue("a[throw ''] = 0;");
   }
 
@@ skipping 11 matching lines @@
 
   void test_binaryExpression_and() {
     _assertFalse("a && b;");
   }
 
   void test_binaryExpression_and_lhs() {
     _assertTrue("throw '' && b;");
   }
 
   void test_binaryExpression_and_rhs() {
-    _assertTrue("a && (throw '');");
+    _assertFalse("a && (throw '');");
   }
 
   void test_binaryExpression_and_rhs2() {
-    _assertTrue("false && (throw '');");
+    _assertFalse("false && (throw '');");
   }
 
   void test_binaryExpression_and_rhs3() {
-    _assertFalse("true && (throw '');");
+    _assertTrue("true && (throw '');");
+  }
+
+  void test_binaryExpression_ifNull() {
+    _assertFalse("a ?? b;");
+  }
+
+  void test_binaryExpression_ifNull_lhs() {
+    _assertTrue("throw '' ?? b;");
+  }
+
+  void test_binaryExpression_ifNull_rhs() {
+    _assertFalse("a ?? (throw '');");
+  }
+
+  void test_binaryExpression_ifNull_rhs2() {
+    _assertFalse("null ?? (throw '');");
   }
 
   void test_binaryExpression_or() {
     _assertFalse("a || b;");
   }
 
   void test_binaryExpression_or_lhs() {
     _assertTrue("throw '' || b;");
   }
 
   void test_binaryExpression_or_rhs() {
-    _assertTrue("a || (throw '');");
+    _assertFalse("a || (throw '');");
   }
 
   void test_binaryExpression_or_rhs2() {
-    _assertTrue("true || (throw '');");
+    _assertFalse("true || (throw '');");
   }
 
   void test_binaryExpression_or_rhs3() {
-    _assertFalse("false || (throw '');");
+    _assertTrue("false || (throw '');");
   }
 
   void test_block_empty() {
     _assertFalse("{}");
   }
 
   void test_block_noReturn() {
     _assertFalse("{ int i = 0; }");
   }
 
@@ skipping 30 matching lines @@
   }
 
   void test_conditional_ifElse_noThrow() {
     _assertFalse("c ? i : j;");
   }
 
   void test_conditional_ifElse_thenThrow() {
     _assertFalse("c ? throw '' : j;");
   }
 
+  void test_conditionalAccess() {
+    _assertFalse("a?.b;");
+  }
+
+  void test_conditionalAccess_lhs() {
+    _assertTrue("(throw '')?.b;");
+  }
+
+  void test_conditionalAccessAssign() {
+    _assertFalse("a?.b = c;");
+  }
+
+  void test_conditionalAccessAssign_lhs() {
+    _assertTrue("(throw '')?.b = c;");
+  }
+
+  void test_conditionalAccessAssign_rhs() {
+    _assertFalse("a?.b = throw '';");
+  }
+
+  void test_conditionalAccessAssign_rhs2() {
+    _assertFalse("null?.b = throw '';");
+  }
+
+  void test_conditionalAccessIfNullAssign() {
+    _assertFalse("a?.b ??= c;");
+  }
+
+  void test_conditionalAccessIfNullAssign_lhs() {
+    _assertTrue("(throw '')?.b ??= c;");
+  }
+
+  void test_conditionalAccessIfNullAssign_rhs() {
+    _assertFalse("a?.b ??= throw '';");
+  }
+
+  void test_conditionalAccessIfNullAssign_rhs2() {
+    _assertFalse("null?.b ??= throw '';");
+  }
+
+  void test_conditionalCall() {
+    _assertFalse("a?.b(c);");
+  }
+
+  void test_conditionalCall_lhs() {
+    _assertTrue("(throw '')?.b(c);");
+  }
+
+  void test_conditionalCall_rhs() {
+    _assertFalse("a?.b(throw '');");
+  }
+
+  void test_conditionalCall_rhs2() {
+    _assertFalse("null?.b(throw '');");
+  }
+
   void test_creation() {
     expect(new ExitDetector(), isNotNull);
   }
 
   void test_doStatement_throwCondition() {
     _assertTrue("{ do {} while (throw ''); }");
   }
 
   void test_doStatement_true_break() {
     _assertFalse("{ do { break; } while (true); }");
@@ skipping 136 matching lines @@
   }
 
   void test_ifElse_noReturn() {
     _assertFalse("if (c) i++; else j++;");
   }
 
   void test_ifElse_thenReturn() {
     _assertFalse("if (c) return 0; else j++;");
   }
 
+  void test_ifNullAssign() {
+    _assertFalse("a ??= b;");
+  }
+
+  void test_ifNullAssign_rhs() {
+    _assertFalse("a ??= throw '';");
+  }
+
   void test_indexExpression() {
     _assertFalse("a[b];");
   }
 
   void test_indexExpression_index() {
     _assertTrue("a[throw ''];");
   }
 
   void test_indexExpression_target() {
     _assertTrue("throw ''[b];");
@@ skipping 1587 matching lines @@
     if (_expectedExternalScriptName == null) {
       expect(scriptSource, isNull, reason: "script $scriptIndex");
     } else {
       expect(scriptSource, isNotNull, reason: "script $scriptIndex");
       String actualExternalScriptName = scriptSource.shortName;
       expect(actualExternalScriptName, _expectedExternalScriptName,
           reason: "script $scriptIndex");
     }
   }
 }