Issue 1330703002: Do not emit coverage/callsite info for implicit closure functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1330703002: Do not emit coverage/callsite info for implicit closure functions. (Closed)

Created:
5 years, 3 months ago by turnidge

Modified:
5 years, 3 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Do not emit coverage/callsite info for implicit closure functions. They are all forwarding functions now, and this was causing some oddities in the observatory UI where some functions had coverage info on their first line and some didn't. The coverage info always reflected merely whether or not the closure had been invoked yet, which was confusing. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/8d68f9105509b956385aadd3af56e1fe78827a9d

Patch Set 1 #

Patch Set 2 : fix test #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -11 lines)			Patch
	M	runtime/observatory/tests/service/coverage_test.dart	View	1	4 chunks	+7 lines, -7 lines	0 comments	Download
	M	runtime/vm/coverage.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

turnidge

5 years, 3 months ago (2015-09-04 21:48:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
8d68f9105509b956385aadd3af56e1fe78827a9d (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages