Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2367)

Unified Diff: runtime/observatory/tests/service/coverage_test.dart

Issue 1330703002: Do not emit coverage/callsite info for implicit closure functions. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: fix test Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/coverage.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/coverage_test.dart
diff --git a/runtime/observatory/tests/service/coverage_test.dart b/runtime/observatory/tests/service/coverage_test.dart
index 4b44b37223561c86db848fe5932fbd5139289157..5223092af4ba30c52d5a7cf4980191094bf82a6c 100644
--- a/runtime/observatory/tests/service/coverage_test.dart
+++ b/runtime/observatory/tests/service/coverage_test.dart
@@ -11,7 +11,7 @@ import 'dart:developer';
int globalVar = 100;
class MyClass {
- static void myFunction(int value) {
+ static void myFunction(int value) {
if (value < 0) {
print("negative");
} else {
@@ -22,9 +22,9 @@ class MyClass {
static void otherFunction(int value) {
if (value < 0) {
- print("otherFunction <");
+ print("otherFunction <");
} else {
- print("otherFunction >=");
+ print("otherFunction >=");
}
}
}
@@ -79,8 +79,8 @@ hasStoppedAtBreakpoint,
expect(coverage['coverage'][0]['hits'],
equals([15, 1, 16, 0, 18, 1, 20, 1,
24, 1, 25, 1, 27, 0]));
- expect(coverage['coverage'][1]['hits'].take(12),
- equals([33, 1, 34, 1, 32, 1, 105, 2, 105, 1]));
+ expect(coverage['coverage'][1]['hits'],
+ equals([33, 1, 34, 1, 105, 2]));
// Script
await cls.load();
@@ -91,8 +91,8 @@ hasStoppedAtBreakpoint,
expect(coverage['coverage'][0]['hits'],
equals([15, 1, 16, 0, 18, 1, 20, 1,
24, 1, 25, 1, 27, 0]));
- expect(coverage['coverage'][1]['hits'].take(12),
- equals([33, 1, 34, 1, 32, 1, 105, 2, 105, 1]));
+ expect(coverage['coverage'][1]['hits'],
+ equals([33, 1, 34, 1, 105, 2]));
// Isolate
coverage = await isolate.invokeRpcNoUpgrade('_getCoverage', {});
« no previous file with comments | « no previous file | runtime/vm/coverage.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698