Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1327123003: Fix crash when deferred loading would encounter an unresolved super setter. (Closed)

Created:
5 years, 3 months ago by sigurdm
Modified:
5 years, 3 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix crash when deferred loading would encounter an unresolved super setter. BUG= R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/18bb772cddaaeb735ed3edc833dc10836abb241b

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -3 lines) Patch
M pkg/compiler/lib/src/deferred_load.dart View 1 chunk +5 lines, -0 lines 0 comments Download
A + tests/language/deferred_super_dependency_lib.dart View 1 chunk +5 lines, -3 lines 0 comments Download
A tests/language/deferred_super_dependency_test.dart View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sigurdm
5 years, 3 months ago (2015-09-09 11:15:49 UTC) #3
Johnni Winther
lgtm
5 years, 3 months ago (2015-09-09 11:50:27 UTC) #4
sigurdm
5 years, 3 months ago (2015-09-09 12:56:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
18bb772cddaaeb735ed3edc833dc10836abb241b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698