Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: pkg/compiler/lib/src/deferred_load.dart

Issue 1327123003: Fix crash when deferred loading would encounter an unresolved super setter. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/deferred_super_dependency_lib.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/deferred_load.dart
diff --git a/pkg/compiler/lib/src/deferred_load.dart b/pkg/compiler/lib/src/deferred_load.dart
index 378710d85f6b94ca58399d62be5a9ddd91e25323..fd1f77c4ec5fa6413a339ebf57ca5957b225972b 100644
--- a/pkg/compiler/lib/src/deferred_load.dart
+++ b/pkg/compiler/lib/src/deferred_load.dart
@@ -246,6 +246,11 @@ class DeferredLoadTask extends CompilerTask {
Set<ConstantValue> constants,
isMirrorUsage) {
+ if (element.isErroneous) {
+ // Erroneous elements are ignored.
+ return;
+ }
+
/// Recursively collects all the dependencies of [type].
void collectTypeDependencies(DartType type) {
if (type is GenericType) {
« no previous file with comments | « no previous file | tests/language/deferred_super_dependency_lib.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698