Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1326853003: - Do not access the first character in zero-length strings. (Closed)

Created:
5 years, 3 months ago by Ivan Posva
Modified:
5 years, 3 months ago
Reviewers:
ricow1, zra, srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Do not access the first character in zero-length strings. - Make sure to print all 64-bits of the Dart_Port if necessary. R=ricow@google.com Committed: https://github.com/dart-lang/sdk/commit/6446cc5096daf273b7de097e0ca8e83a34431bca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -22 lines) Patch
M runtime/vm/coverage.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/symbols.cc View 2 chunks +25 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Ivan Posva
5 years, 3 months ago (2015-09-03 06:16:55 UTC) #2
ricow1
lgtm
5 years, 3 months ago (2015-09-03 06:21:06 UTC) #3
Ivan Posva
Committed patchset #1 (id:1) manually as 6446cc5096daf273b7de097e0ca8e83a34431bca (presubmit successful).
5 years, 3 months ago (2015-09-03 06:22:21 UTC) #4
srdjan
5 years, 3 months ago (2015-09-03 14:45:20 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698