runtime/vm/coverage.cc - Issue 1326853003: - Do not access the first character in zero-length strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/coverage.cc

Issue 1326853003: - Do not access the first character in zero-length strings. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/coverage.cc

diff --git a/runtime/vm/coverage.cc b/runtime/vm/coverage.cc

index f91eaa9492b232a498937f792d223ed6c330395b..7892e37fea4e5aa702c9fd6a7ef3b592018cd46b 100644

--- a/runtime/vm/coverage.cc

+++ b/runtime/vm/coverage.cc

@@ -248,7 +248,7 @@ void CodeCoverage::Write(Isolate* isolate) {

JSONStream stream;

PrintJSON(isolate, &stream, NULL, false);

- const char* format = "%s/dart-cov-%" Pd "-%" Pd ".json";

+ const char* format = "%s/dart-cov-%" Pd "-%" Pd64 ".json";

intptr_t pid = OS::ProcessId();

intptr_t len = OS::SNPrint(NULL, 0, format,

FLAG_coverage_dir, pid, isolate->main_port());

« no previous file with comments | « no previous file | runtime/vm/symbols.cc » ('j') | no next file with comments »