Put in a teardown for the docs test, fixed dom.py to actually run it correctly, added PRESUMBIT.

Put in a teardown for the docs test, fixed dom.py to actually run it correctly.
This also adds a PRESUBMIT.py, which will run on a commit and warn the
committer if the docs need to be regenerated. This only runs if
the html_dart2js, et. al. files have been modified.

Committed: https://code.google.com/p/dart/source/detail?r=20820

[Andrei Mouravski, 2013-04-01 01:03:42]

We haven't been using PRESUBMIT.py for anything, and I think this is just one
little check to make sure our HTML docs stay fresh.

TODO (in a different CL): Presubmit check to make sure that go.sh was run
recently. This is a bigger operation, so I don't think I can do the same kind of
check of diffing a new generated file. However, I could check either that:
a) if anything under tools/dom/ has changed, then sdk/lib has also changed, 
b) record last time that go.sh was run, and compare it to sdk/lib,
c) something smarter about actually looking at files.

Another TODO is to check if there are modifications to sdk/lib before running
go.sh to make sure that docs are not clobbered by the new run.

[Emily Fortuna, 2013-04-01 17:41:20]

https://codereview.chromium.org/13251005/diff/5001/tools/dom/PRESUBMIT.py
File tools/dom/PRESUBMIT.py (right):

https://codereview.chromium.org/13251005/diff/5001/tools/dom/PRESUBMIT.py#new...
tools/dom/PRESUBMIT.py:7: 
Just a few comments here talking about how this file is used, please.

https://codereview.chromium.org/13251005/diff/5001/tools/dom/PRESUBMIT.py#new...
tools/dom/PRESUBMIT.py:17: 
also, perhaps I'm missing something, but how is this called? What is "input_api"
exactly?

https://codereview.chromium.org/13251005/diff/5001/tools/dom/docs/test/docs_t...
File tools/dom/docs/test/docs_test.dart (right):

https://codereview.chromium.org/13251005/diff/5001/tools/dom/docs/test/docs_t...
tools/dom/docs/test/docs_test.dart:17: group('docs', () {
if there's only one test, there's no real compelling reason to add a "group" to
this test file.

https://codereview.chromium.org/13251005/diff/5001/tools/dom/dom.py
File tools/dom/dom.py (right):

https://codereview.chromium.org/13251005/diff/5001/tools/dom/dom.py#newcode159
tools/dom/dom.py:159: return subprocess.call(args)
Suggestion: consider using Popen instead of subprocess, so we can get the output
(any error output from running the command would be helpful to diagnose what's
going wrong):
 
pipe = subprocess.Popen(args, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
output, error = pipe.communicate()
if output:
  print output
if error:
  print error

This change is completely optional if its functioning as needed for right now.

https://codereview.chromium.org/13251005/diff/5001/tools/dom/dom.py#newcode203
tools/dom/dom.py:203: success *= not bool(commands[command][0]())
I find this a little more abstruse than it needs to be. How about: 

success = success and (commands[command][0]() == 0)

[blois, 2013-04-01 20:35:15]

https://codereview.chromium.org/13251005/diff/5001/tools/dom/dom.py
File tools/dom/dom.py (right):

https://codereview.chromium.org/13251005/diff/5001/tools/dom/dom.py#newcode70
tools/dom/dom.py:70: '--package-root=%s' % os.path.join(dart_out_dir,
'packages/'),
Is the trailing slash required? If not, omit for portability.

https://codereview.chromium.org/13251005/diff/5001/tools/dom/dom.py#newcode159
tools/dom/dom.py:159: return subprocess.call(args)
On 2013/04/01 17:41:20, Emily Fortuna wrote:
> Suggestion: consider using Popen instead of subprocess, so we can get the
output
> (any error output from running the command would be helpful to diagnose what's
> going wrong):
>  
> pipe = subprocess.Popen(args, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
> output, error = pipe.communicate()
> if output:
>   print output
> if error:
>   print error
> 
> This change is completely optional if its functioning as needed for right now.

The output does go to the console already, but I'm unfamiliar with these APIs in
general, so there could easily be a better way.

[Andrei Mouravski, 2013-04-01 22:43:07]

PTAL.

https://codereview.chromium.org/13251005/diff/5001/tools/dom/PRESUBMIT.py
File tools/dom/PRESUBMIT.py (right):

https://codereview.chromium.org/13251005/diff/5001/tools/dom/PRESUBMIT.py#new...
tools/dom/PRESUBMIT.py:7: 
On 2013/04/01 17:41:20, Emily Fortuna wrote:
> Just a few comments here talking about how this file is used, please. 

Done.

https://codereview.chromium.org/13251005/diff/5001/tools/dom/PRESUBMIT.py#new...
tools/dom/PRESUBMIT.py:17: 
On 2013/04/01 17:41:20, Emily Fortuna wrote:
> also, perhaps I'm missing something, but how is this called? What is
"input_api"
> exactly?
http://www.chromium.org/developers/how-tos/depottools/presubmit-scripts

https://codereview.chromium.org/13251005/diff/5001/tools/dom/docs/test/docs_t...
File tools/dom/docs/test/docs_test.dart (right):

https://codereview.chromium.org/13251005/diff/5001/tools/dom/docs/test/docs_t...
tools/dom/docs/test/docs_test.dart:17: group('docs', () {
On 2013/04/01 17:41:20, Emily Fortuna wrote:
> if there's only one test, there's no real compelling reason to add a "group"
to
> this test file.

It's the only way to register the tearDown() to happen after the test is run.

https://codereview.chromium.org/13251005/diff/5001/tools/dom/dom.py
File tools/dom/dom.py (right):

https://codereview.chromium.org/13251005/diff/5001/tools/dom/dom.py#newcode70
tools/dom/dom.py:70: '--package-root=%s' % os.path.join(dart_out_dir,
'packages/'),
On 2013/04/01 20:35:15, blois wrote:
> Is the trailing slash required? If not, omit for portability.

Sadly, yes:
https://code.google.com/p/dart/issues/detail?id=6615
https://code.google.com/p/dart/issues/detail?id=3361

https://codereview.chromium.org/13251005/diff/5001/tools/dom/dom.py#newcode159
tools/dom/dom.py:159: return subprocess.call(args)
On 2013/04/01 20:35:15, blois wrote:
> On 2013/04/01 17:41:20, Emily Fortuna wrote:
> > Suggestion: consider using Popen instead of subprocess, so we can get the
> output
> > (any error output from running the command would be helpful to diagnose
what's
> > going wrong):
> >  
> > pipe = subprocess.Popen(args, stdout=subprocess.PIPE,
stderr=subprocess.PIPE)
> > output, error = pipe.communicate()
> > if output:
> >   print output
> > if error:
> >   print error
> > 
> > This change is completely optional if its functioning as needed for right
now.
> 
> The output does go to the console already, but I'm unfamiliar with these APIs
in
> general, so there could easily be a better way.

Done.

https://codereview.chromium.org/13251005/diff/5001/tools/dom/dom.py#newcode203
tools/dom/dom.py:203: success *= not bool(commands[command][0]())
On 2013/04/01 17:41:20, Emily Fortuna wrote:
> I find this a little more abstruse than it needs to be. How about: 
> 
> success = success and (commands[command][0]() == 0) 

Done.

[Emily Fortuna, 2013-04-02 01:38:39]

lgtm

[blois, 2013-04-02 16:46:27]

lgtm

[Andrei Mouravski, 2013-04-02 21:14:14]

Committed patchset #6 manually as r20820 (presubmit successful).