Put in a teardown for the docs test, fixed dom.py to actually run it correctly, added PRESUMBIT.

tools/dom/dom.py

 #!/usr/bin/python
 
 # Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 # A script which makes it easy to execute common DOM-related tasks
 
 import os
 import subprocess
@@ skipping 16 matching lines @@
      '  dom.py gen test_drt html/element_test\n'
      '\n'
      'Or re-generate DOM classes and run the Dart analyzer:\n'
      '  dom.py gen analyze\n')
   print('Commands: ')
   for cmd in sorted(commands.keys()):
     print('\t%s - %s' % (cmd, commands[cmd][1]))
 
 def analyze():
   ''' Runs the dart analyzer. '''
-  call([
+  return call([
     os.path.join(dart_out_dir, 'dart-sdk', 'bin', 'dart_analyzer'),
     os.path.join('tests', 'html', 'element_test.dart'),
     '--dart-sdk', 'sdk',
     '--show-sdk-warnings',
   ])
 
 def build():
   ''' Builds the Dart binary '''
-  call([
+  return call([
     os.path.join('tools', 'build.py'),
     '--mode=release',
     '--arch=ia32',
     'runtime',
   ])
 
 def dart2js():
   compile_dart2js(argv.pop(0), True)
 
 def dartc():
-  call([
+  return call([
     os.path.join('tools', 'test.py'),
     '-m',
     'release',
     '-c',
     'dartc',
     '-r',
     'none'
   ])
 
+def docs():
+  return call([
+    os.path.join(dart_out_dir, 'dart-sdk', 'bin', 'dart'),
+    '--package-root=%s' % os.path.join(dart_out_dir, 'packages/'),

[blois, 2013/04/01 20:35:15]

Is the trailing slash required? If not, omit for portability.

[Andrei Mouravski, 2013/04/01 22:43:07]

Sadly, yes:
https://code.google.com/p/dart/issues/detail?id=6615
https://code.google.com/p/dart/issues/detail?id=3361

+    os.path.join('tools', 'dom', 'docs', 'bin', 'docs.dart'),
+  ])
+
+def test_docs():
+  return call([
+    os.path.join('tools', 'test.py'),
+    '--mode=release',
+    '--checked',
+    'docs'
+  ])
+
 def compile_dart2js(dart_file, checked):
   out_file = dart_file + '.js'
   dart2js_path = os.path.join(dart_out_dir, 'dart-sdk', 'bin', 'dart2js')
   args = [
     dart2js_path,
     dart_file,
     '--library-root=sdk/',
     '--disallow-unsafe-eval',
     '-o%s' % out_file
   ]
   if checked:
     args.append('--checked')
 
   call(args)
   return out_file
 
 def gen():
   os.chdir(os.path.join('tools', 'dom', 'scripts'))
-  call([
-    'go.sh',
-  ])
+  return call(os.path.join(os.getcwd(), 'go.sh'))
 
 def http_server():
   print('Browse tests at '
       '\033[94mhttp://localhost:5400/root_build/generated_tests/\033[0m')
-  call([
+  return call([
     utils.DartBinary(),
     os.path.join('tools', 'testing', 'dart', 'http_server.dart'),
     '--port=5400',
     '--crossOriginPort=5401',
     '--network=0.0.0.0',
     '--build-directory=%s' % os.path.join('out', 'ReleaseIA32')
   ])
 
 def size_check():
   ''' Displays the dart2js size of swarm. '''
   dart_file = os.path.join('samples', 'swarm', 'swarm.dart')
   out_file = compile_dart2js(dart_file, False)
 
-  subprocess.call([
+  return call([
     'du',
     '-kh',
     '--apparent-size',
     out_file,
   ])
 
   os.remove(out_file)
   os.remove(out_file + '.deps')
   os.remove(out_file + '.map')
 
@@ skipping 15 matching lines @@
     '--checked',
     '--arch=ia32',
     '-v',
   ]
   if argv:
     cmd.append(argv.pop(0))
   else:
     print(
         'Test commands should be followed by tests to run. Defaulting to html')
     cmd.append('html')
-  call(cmd)
+  return call(cmd)
 
 def call(args):
-  print (' '.join(args))
-  subprocess.call(args)
+  print ' '.join(args)
+  return subprocess.call(args)

[Emily Fortuna, 2013/04/01 17:41:20]

Suggestion: consider using Popen instead of subprocess, so we can get the output
(any error output from running the command would be helpful to diagnose what's
going wrong):
 
pipe = subprocess.Popen(args, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
output, error = pipe.communicate()
if output:
  print output
if error:
  print error

This change is completely optional if its functioning as needed for right now.

[blois, 2013/04/01 20:35:15]

The output does go to the console already, but I'm unfamiliar with these APIs in
general, so there could easily be a better way.

[Andrei Mouravski, 2013/04/01 22:43:07]

Done.

 
 def init_dir():
   ''' Makes sure that we're always rooted in the dart root folder.'''
   dart_dir = os.path.abspath(os.path.join(
       os.path.dirname(os.path.realpath(__file__)),
       os.path.pardir, os.path.pardir))
   os.chdir(dart_dir)
 
 commands = {
   'analyze': [analyze, 'Run the dart analyzer'],
   'build': [build, 'Build dart in release mode'],
   'dart2js': [dart2js, 'Run dart2js on the .dart file specified'],
   'dartc': [dartc, 'Runs dartc in release mode'],
+  'docs': [docs, 'Generates docs.json'],
   'gen': [gen, 'Re-generate DOM generated files (run go.sh)'],
   'size_check': [size_check, 'Check the size of dart2js compiled Swarm'],
+  'test_docs': [test_docs, 'Tests docs.dart'],
   'test_chrome': [test_chrome, 'Run tests in checked mode in Chrome.\n'
       '\t\tOptionally provide name of test to run.'],
   'test_drt': [test_drt, 'Run tests in checked mode in DumpRenderTree.\n'
       '\t\tOptionally provide name of test to run.'],
   'test_ff': [test_ff, 'Run tests in checked mode in Firefox.\n'
       '\t\tOptionally provide name of test to run.'],
   'http_server': [http_server, 'Starts the testing server for manually '
       'running browser tests.'],
 }
 
 def main(argv):
+  success = True
   argv.pop(0)
 
   if not argv:
     help()
+    success = False
 
   while (argv):
     init_dir()
     command = argv.pop(0)
 
     if not command in commands:
       help();
-      return
-    commands[command][0]()
+      success = False
+      break
+    success *= not bool(commands[command][0]())

[Emily Fortuna, 2013/04/01 17:41:20]

I find this a little more abstruse than it needs to be. How about: 

success = success and (commands[command][0]() == 0) 

[Andrei Mouravski, 2013/04/01 22:43:07]

Done.

+
+  sys.exit(not success)
 
 if __name__ == '__main__':
   main(sys.argv)