Add `packages` parameter to `Isolate.spawnUri`.

Add `packages` parameter to `Isolate.spawnUri`.

No implementation supplied, marked as "not implemented everywhere".


BUG= http://dartbug.com/23951
R=iposva@google.com, sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/ff65079c475129a8842ff3857f152d577b708731

[Lasse Reichstein Nielsen, 2015-09-04 09:37:05]

lrn@google.com changed reviewers:
+ iposva@google.com, sigmund@google.com

[Siggi Cherem (dart-lang), 2015-09-04 15:32:01]

lgtm

https://codereview.chromium.org/1323373002/diff/1/sdk/lib/_internal/js_runtim...
File sdk/lib/_internal/js_runtime/lib/isolate_patch.dart (right):

https://codereview.chromium.org/1323373002/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/isolate_patch.dart:72: if (packageRoot != null)
throw new UnimplementedError("packageRoot");
could we add a similar exception for packages?

[Lasse Reichstein Nielsen, 2015-09-09 12:57:17]

Ping Ivan.

https://codereview.chromium.org/1323373002/diff/1/sdk/lib/_internal/js_runtim...
File sdk/lib/_internal/js_runtime/lib/isolate_patch.dart (right):

https://codereview.chromium.org/1323373002/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/isolate_patch.dart:72: if (packageRoot != null)
throw new UnimplementedError("packageRoot");
On 2015/09/04 15:32:01, Siggi Cherem (dart-lang) wrote:
> could we add a similar exception for packages?

Done.

[Ivan Posva, 2015-09-11 08:45:05]

LGTM once the specification is clarified.

-Ivan

https://codereview.chromium.org/1323373002/diff/20001/sdk/lib/isolate/isolate...
File sdk/lib/isolate/isolate.dart (right):

https://codereview.chromium.org/1323373002/diff/20001/sdk/lib/isolate/isolate...
sdk/lib/isolate/isolate.dart:228: * as by
`packages["foo"].resolve("baz/bar.dart")
It will be quite tricky to swap the last characters in the filenames before any
potential extension. What is missing from the documentation: if there are more
than two path segments, how does the swapping proceed, or are the last
characters just rotated?

[Lasse Reichstein Nielsen, 2015-09-11 11:07:59]

Committed patchset #3 (id:40001) manually as
ff65079c475129a8842ff3857f152d577b708731 (presubmit successful).

[Lasse Reichstein Nielsen, 2015-09-15 11:58:03]

https://codereview.chromium.org/1323373002/diff/20001/sdk/lib/isolate/isolate...
File sdk/lib/isolate/isolate.dart (right):

https://codereview.chromium.org/1323373002/diff/20001/sdk/lib/isolate/isolate...
sdk/lib/isolate/isolate.dart:228: * as by
`packages["foo"].resolve("baz/bar.dart")
Very funny! Fixed :P
(and good catch!)