Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1602)

Unified Diff: sdk/lib/_internal/js_runtime/lib/isolate_patch.dart

Issue 1323373002: Add `packages` parameter to `Isolate.spawnUri`. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Fix typo in documentation. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/isolate_patch.dart ('k') | sdk/lib/isolate/isolate.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/js_runtime/lib/isolate_patch.dart
diff --git a/sdk/lib/_internal/js_runtime/lib/isolate_patch.dart b/sdk/lib/_internal/js_runtime/lib/isolate_patch.dart
index eb681071b2adf16a393523cc2a7fe1012b7a6bc2..70eda5b5e973708798fe729f2faf6b5eec296c82 100644
--- a/sdk/lib/_internal/js_runtime/lib/isolate_patch.dart
+++ b/sdk/lib/_internal/js_runtime/lib/isolate_patch.dart
@@ -62,9 +62,15 @@ class Isolate {
@patch
static Future<Isolate> spawnUri(
Uri uri, List<String> args, var message,
- {bool paused: false, bool checked, Uri packageRoot, bool errorsAreFatal,
- SendPort onExit, SendPort onError}) {
+ {bool paused: false,
+ bool checked,
+ Uri packageRoot,
+ Map<String, Uri> packages,
+ bool errorsAreFatal,
+ SendPort onExit,
+ SendPort onError}) {
if (packageRoot != null) throw new UnimplementedError("packageRoot");
+ if (packages != null) throw new UnimplementedError("packages");
bool forcePause = (errorsAreFatal != null) ||
(onExit != null) ||
(onError != null);
@@ -78,6 +84,7 @@ class Isolate {
} else if (args != null) {
throw new ArgumentError("Args must be a list of Strings $args");
}
+ // TODO: Handle [packageRoot]/[packages] somehow, possibly by throwing.
// TODO: Consider passing the errorsAreFatal/onExit/onError values
// as arguments to the internal spawnUri instead of setting
// them after the isolate has been created.
« no previous file with comments | « runtime/lib/isolate_patch.dart ('k') | sdk/lib/isolate/isolate.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698