Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 1322043002: More elimination of new space allocation, fix bugs in Symbols::FromConcatAll (Closed)

Created:
5 years, 3 months ago by srdjan
Modified:
5 years, 3 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

More elimination of new space allocation, fix bugs in Symbols::FromConcatAll BUG= R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/59db5010a92543e502249b692c869b58da58fefb

Patch Set 1 #

Patch Set 2 : Handle TwoByteStrings #

Patch Set 3 : Fix/delete comments #

Patch Set 4 : synced #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -23 lines) Patch
M runtime/vm/object.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/parser.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M runtime/vm/symbols.cc View 1 2 1 chunk +49 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
srdjan
5 years, 3 months ago (2015-08-31 23:49:27 UTC) #2
regis
LGTM
5 years, 3 months ago (2015-09-01 00:52:41 UTC) #3
srdjan
5 years, 3 months ago (2015-09-01 17:30:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
59db5010a92543e502249b692c869b58da58fefb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698