More elimination of new space allocation, fix bugs in Symbols::FromConcatAll

runtime/vm/symbols.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/symbols.h"
 
 #include "vm/handles.h"
 #include "vm/handles_impl.h"
 #include "vm/hash_table.h"
 #include "vm/isolate.h"
@@ skipping 379 matching lines @@
   } else {
     return NewSymbol(ConcatString(str1, str2));
   }
 }
 
 
 // TODO(srdjan): If this becomes performance critical code, consider looking
 // up symbol from pieces instead of concatenating them first into a big string.
 RawString* Symbols::FromConcatAll(
     const GrowableHandlePtrArray<const String>& strs) {
-  GrowableArray<const char*> cchars(strs.length());
-  GrowableArray<intptr_t> lengths(strs.length());
+  const intptr_t strs_length = strs.length();
+  GrowableArray<intptr_t> lengths(strs_length);
+
   intptr_t len_sum = 0;
-  for (intptr_t i = 0; i < strs.length(); i++) {
-    const char* to_cstr = strs[i].ToCString();
-    intptr_t len = strlen(to_cstr);
-    cchars.Add(to_cstr);
-    lengths.Add(len);
-    len_sum += len;
+  bool is_one_byte_string = true;
+  for (intptr_t i = 0; i < strs_length; i++) {
+    const String& str = strs[i];
+    const intptr_t str_len = str.Length();
+    if ((String::kMaxElements - len_sum) < str_len) {
+      Exceptions::ThrowOOM();
+      UNREACHABLE();
+    }
+    len_sum += str_len;
+    lengths.Add(str_len);
+    if (!str.IsOneByteString()) {
+      is_one_byte_string = false;
+    }
   }
 
   Zone* zone = Thread::Current()->zone();
-  char* buffer = zone->Alloc<char>(len_sum);
-  const char* const orig_buffer = buffer;
-  for (intptr_t i = 0; i < cchars.length(); i++) {
-    intptr_t len = lengths[i];
-    strncpy(buffer, cchars[i], len);
-    buffer += len;
+
+  if (is_one_byte_string) {
+    uint8_t* buffer = zone->Alloc<uint8_t>(len_sum);
+    const uint8_t* const orig_buffer = buffer;
+    for (intptr_t i = 0; i < strs_length; i++) {
+      NoSafepointScope no_safepoint;
+      intptr_t str_len = lengths[i];
+      const String& str = strs[i];
+      memmove(buffer, OneByteString::CharAddr(str, 0), str_len);
+      buffer += str_len;
+    }
+    ASSERT(len_sum == buffer - orig_buffer);
+    return Symbols::FromLatin1(orig_buffer, len_sum);
+  } else {
+    uint16_t* buffer = zone->Alloc<uint16_t>(len_sum);
+    const uint16_t* const orig_buffer = buffer;
+    for (intptr_t i = 0; i < strs_length; i++) {
+      NoSafepointScope no_safepoint;
+      intptr_t str_len = lengths[i];
+      const String& str = strs[i];
+      if (str.IsTwoByteString()) {
+        memmove(buffer, TwoByteString::CharAddr(str, 0), str_len * 2);
+      } else {
+        uint8_t* src_p = OneByteString::CharAddr(str, 0);
+        for (int n = 0; n < str_len; n++) {
+          buffer[n] = src_p[n];
+        }
+      }
+      buffer += str_len;
+    }
+    ASSERT(len_sum == buffer - orig_buffer);
+    return Symbols::FromUTF16(orig_buffer, len_sum);
   }
-  ASSERT(len_sum == buffer - orig_buffer);
-  return Symbols::New(orig_buffer, len_sum);
 }
 
 
 // StringType can be StringSlice, ConcatString, or {Latin1,UTF16,UTF32}Array.
 template<typename StringType>
 RawString* Symbols::NewSymbol(const StringType& str) {
   Thread* thread = Thread::Current();
   Isolate* isolate = thread->isolate();
   Zone* zone = thread->zone();
   String& symbol = String::Handle(zone);
@@ skipping 66 matching lines @@
 RawObject* Symbols::GetVMSymbol(intptr_t object_id) {
   ASSERT(IsVMSymbolId(object_id));
   intptr_t i = (object_id - kMaxPredefinedObjectIds);
   if ((i > kIllegal) && (i < Symbols::kMaxPredefinedId)) {
     return symbol_handles_[i]->raw();
   }
   return Object::null();
 }
 
 }  // namespace dart