Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 13196007: Replace defer() with Future.of in pub. (Closed)

Created:
7 years, 8 months ago by nweiz
Modified:
7 years, 8 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Replace defer() with Future.of in pub. Committed: https://code.google.com/p/dart/source/detail?r=20703

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -32 lines) Patch
M utils/pub/command_uploader.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/entrypoint.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M utils/pub/error_group.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/git_source.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/pub/hosted_source.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/io.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/oauth2.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/path_source.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/pub/pub.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/pub/utils.dart View 1 chunk +0 lines, -12 lines 0 comments Download
M utils/tests/pub/test_pub.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/version_solver_test.dart View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
7 years, 8 months ago (2013-03-29 22:25:49 UTC) #1
Bob Nystrom
LGTM.
7 years, 8 months ago (2013-03-29 23:59:46 UTC) #2
nweiz
7 years, 8 months ago (2013-03-30 00:08:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20703 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698