Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: utils/pub/error_group.dart

Issue 13196007: Replace defer() with Future.of in pub. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « utils/pub/entrypoint.dart ('k') | utils/pub/git_source.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library error_group; 5 library error_group;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 8
9 import 'utils.dart'; 9 import 'utils.dart';
10 10
(...skipping 246 matching lines...) Expand 10 before | Expand all | Expand 10 after
257 onDone: onDone, 257 onDone: onDone,
258 unsubscribeOnError: true); 258 unsubscribeOnError: true);
259 } 259 }
260 260
261 /// Signal that an error from [_group] should be propagated through [this], 261 /// Signal that an error from [_group] should be propagated through [this],
262 /// unless it's already complete. 262 /// unless it's already complete.
263 void _signalError(AsyncError e) { 263 void _signalError(AsyncError e) {
264 if (_isDone) return; 264 if (_isDone) return;
265 _subscription.cancel(); 265 _subscription.cancel();
266 // Call these asynchronously to work around issue 7913. 266 // Call these asynchronously to work around issue 7913.
267 defer(() { 267 new Future.immediate(null).then((_) {
268 _controller.addError(e.error, e.stackTrace); 268 _controller.addError(e.error, e.stackTrace);
269 _controller.close(); 269 _controller.close();
270 }); 270 });
271 } 271 }
272 } 272 }
OLDNEW
« no previous file with comments | « utils/pub/entrypoint.dart ('k') | utils/pub/git_source.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698