Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1319583003: Use the zone in ApiNativeScope for allocating objects in the ApiMessageReader instead of passing in… (Closed)

Created:
5 years, 4 months ago by siva
Modified:
5 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use the zone in ApiNativeScope for allocating objects in the ApiMessageReader instead of passing in an allocator. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/810823f8d5303dca2ea668f4bdfe30a4c0f31c63

Patch Set 1 #

Patch Set 2 : self-code-review #

Patch Set 3 : fix-long-line #

Total comments: 2

Patch Set 4 : address-code-review-comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -63 lines) Patch
M runtime/vm/dart_api_message.h View 1 2 3 2 chunks +9 lines, -12 lines 0 comments Download
M runtime/vm/dart_api_message.cc View 1 2 3 11 chunks +16 lines, -16 lines 0 comments Download
M runtime/vm/native_message_handler.cc View 1 chunk +4 lines, -11 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 22 chunks +22 lines, -24 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
siva
5 years, 4 months ago (2015-08-25 20:42:43 UTC) #2
Cutch
LGTM with comment https://codereview.chromium.org/1319583003/diff/40001/runtime/vm/dart_api_message.h File runtime/vm/dart_api_message.h (right): https://codereview.chromium.org/1319583003/diff/40001/runtime/vm/dart_api_message.h#newcode138 runtime/vm/dart_api_message.h:138: uint8_t* allocator(uint8_t* ptr, intptr_t old_size, intptr_t ...
5 years, 4 months ago (2015-08-25 20:57:53 UTC) #3
siva
https://codereview.chromium.org/1319583003/diff/40001/runtime/vm/dart_api_message.h File runtime/vm/dart_api_message.h (right): https://codereview.chromium.org/1319583003/diff/40001/runtime/vm/dart_api_message.h#newcode138 runtime/vm/dart_api_message.h:138: uint8_t* allocator(uint8_t* ptr, intptr_t old_size, intptr_t new_size) { On ...
5 years, 4 months ago (2015-08-25 21:28:19 UTC) #4
siva
5 years, 4 months ago (2015-08-25 21:48:45 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
810823f8d5303dca2ea668f4bdfe30a4c0f31c63 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698