Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: runtime/vm/native_message_handler.cc

Issue 1319583003: Use the zone in ApiNativeScope for allocating objects in the ApiMessageReader instead of passing in… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: address-code-review-comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/dart_api_message.cc ('k') | runtime/vm/snapshot_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/native_message_handler.h" 5 #include "vm/native_message_handler.h"
6 6
7 #include "vm/dart_api_message.h" 7 #include "vm/dart_api_message.h"
8 #include "vm/isolate.h" 8 #include "vm/isolate.h"
9 #include "vm/message.h" 9 #include "vm/message.h"
10 #include "vm/snapshot.h" 10 #include "vm/snapshot.h"
(...skipping 14 matching lines...) Expand all
25 } 25 }
26 26
27 27
28 #if defined(DEBUG) 28 #if defined(DEBUG)
29 void NativeMessageHandler::CheckAccess() { 29 void NativeMessageHandler::CheckAccess() {
30 ASSERT(Isolate::Current() == NULL); 30 ASSERT(Isolate::Current() == NULL);
31 } 31 }
32 #endif 32 #endif
33 33
34 34
35 static uint8_t* zone_allocator(uint8_t* ptr,
36 intptr_t old_size,
37 intptr_t new_size) {
38 Zone* zone = ApiNativeScope::Current()->zone();
39 return zone->Realloc<uint8_t>(ptr, old_size, new_size);
40 }
41
42
43 bool NativeMessageHandler::HandleMessage(Message* message) { 35 bool NativeMessageHandler::HandleMessage(Message* message) {
44 if (message->IsOOB()) { 36 if (message->IsOOB()) {
45 // We currently do not use OOB messages for native ports. 37 // We currently do not use OOB messages for native ports.
46 UNREACHABLE(); 38 UNREACHABLE();
47 } 39 }
48 // Enter a native scope for handling the message. This will create a 40 // We create a native scope for handling the message.
49 // zone for allocating the objects for decoding the message. 41 // All allocation of objects for decoding the message is done in the
42 // zone associated with this scope.
50 ApiNativeScope scope; 43 ApiNativeScope scope;
51 ApiMessageReader reader(message->data(), message->len(), zone_allocator); 44 ApiMessageReader reader(message->data(), message->len());
52 Dart_CObject* object = reader.ReadMessage(); 45 Dart_CObject* object = reader.ReadMessage();
53 (*func())(message->dest_port(), object); 46 (*func())(message->dest_port(), object);
54 delete message; 47 delete message;
55 return true; 48 return true;
56 } 49 }
57 50
58 } // namespace dart 51 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/dart_api_message.cc ('k') | runtime/vm/snapshot_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698