Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 13195004: Re-enable throwing if we try to set the unit test configuration twice. (Closed)

Created:
7 years, 9 months ago by Emily Fortuna
Modified:
7 years, 9 months ago
Reviewers:
gram, kevmoo-old
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Re-enable throwing if we try to set the unit test configuration twice. BUG= Committed: https://code.google.com/p/dart/source/detail?r=20624

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M pkg/unittest/lib/unittest.dart View 1 chunk +6 lines, -1 line 0 comments Download
M tools/testing/dart/test_suite.dart View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Emily Fortuna
Kevin, You'll be happy to know I found the source of the unittest issue -- ...
7 years, 9 months ago (2013-03-28 17:46:51 UTC) #1
kevmoo-old
Awesome. Thanks. lgtm
7 years, 9 months ago (2013-03-28 17:48:29 UTC) #2
Emily Fortuna
7 years, 9 months ago (2013-03-28 17:49:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20624 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698