Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 13195004: Re-enable throwing if we try to set the unit test configuration twice. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/unittest/lib/unittest.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 35909de47d83b07baf75e153edcfad92605f7fe0..7c9cecf4d22641fbf90c350f74b201aec0c60edb 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -1298,9 +1298,13 @@ class StandardTestSuite extends TestSuite {
* // OtherScripts=file1.dart file2.dart
*
* - You can indicate whether a test is treated as a web-only test by
- * using an explicit import to the dart:html library:
+ * using an explicit import to a part of the the dart:html library:
*
- * #import('dart:html');
+ * import 'dart:html';
+ * import 'dart:web_audio';
+ * import 'dart:indexed_db';
+ * import 'dart:svg';
+ * import 'dart:web_sql';
*
* Most tests are not web tests, but can (and will be) wrapped within
* another script file to test them also on browser environments (e.g.
@@ -1349,7 +1353,8 @@ class StandardTestSuite extends TestSuite {
RegExp isolateStubsRegExp = new RegExp(r"// IsolateStubs=(.*)");
// TODO(gram) Clean these up once the old directives are not supported.
RegExp domImportRegExp =
- new RegExp(r"^[#]?import.*dart:html", multiLine: true);
+ new RegExp(r"^[#]?import.*dart:[html|web_audio|indexed_db|svg|web_sql]",
+ multiLine: true);
RegExp libraryDefinitionRegExp =
new RegExp(r"^[#]?library[\( ]", multiLine: true);
RegExp sourceOrImportRegExp =
« no previous file with comments | « pkg/unittest/lib/unittest.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698