Issue 1318543002: Convert completion API to be future based

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1318543002: Convert completion API to be future based (Closed)

Created:
5 years, 3 months ago by Brian Wilkerson

Modified:
5 years, 3 months ago

Reviewers:
danrubel

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -35 lines)			Patch
M	pkg/analysis_server/lib/completion/completion_core.dart	View	3 chunks	+2 lines, -25 lines	0 comments	Download
M	pkg/analysis_server/lib/completion/completion_dart.dart	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	pkg/analysis_server/lib/src/domain_completion.dart	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/completion_computer_test.dart	View	3 chunks	+5 lines, -3 lines	0 comments	Download

Total messages: 3 (1 generated)

Brian Wilkerson

5 years, 3 months ago (2015-08-25 18:01:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
271bc1f776c630619c2339fd1bd63b570cf916b2 (presubmit successful).