Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: pkg/analysis_server/lib/completion/completion_dart.dart

Issue 1318543002: Convert completion API to be future based (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/completion/completion_dart.dart
diff --git a/pkg/analysis_server/lib/completion/completion_dart.dart b/pkg/analysis_server/lib/completion/completion_dart.dart
index ee215674de8045be6063233f9d91f348f56be8d2..669b2efe44192ef7ba223b5e6d366b463ab6eb7d 100644
--- a/pkg/analysis_server/lib/completion/completion_dart.dart
+++ b/pkg/analysis_server/lib/completion/completion_dart.dart
@@ -5,6 +5,7 @@
library analysis_server.completion.completion_dart;
import 'package:analysis_server/completion/completion_core.dart';
+import 'package:analysis_server/src/protocol.dart';
import 'package:analyzer/src/generated/ast.dart';
import 'package:analyzer/src/generated/engine.dart';
import 'package:analyzer/src/generated/source.dart';
@@ -18,7 +19,7 @@ import 'package:analyzer/src/generated/source.dart';
*/
abstract class DartCompletionContributor extends CompletionContributor {
@override
- CompletionResult computeSuggestions(CompletionRequest request) {
+ List<CompletionSuggestion> computeSuggestions(CompletionRequest request) {
if (request is DartCompletionRequest) {
return internalComputeSuggestions(request);
}
@@ -48,11 +49,10 @@ abstract class DartCompletionContributor extends CompletionContributor {
/**
* Compute a list of completion suggestions based on the given completion
- * [request] and return a result that includes those suggestions. This method
- * is called after specific phases of analysis until the contributor indicates
- * computation is complete by setting [CompletionResult.isLast] to `true`.
+ * [request]. Return the suggestions that were computed.
*/
- CompletionResult internalComputeSuggestions(DartCompletionRequest request);
+ List<CompletionSuggestion> internalComputeSuggestions(
+ DartCompletionRequest request);
}
/**
« no previous file with comments | « pkg/analysis_server/lib/completion/completion_core.dart ('k') | pkg/analysis_server/lib/src/domain_completion.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698