Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 131623004: Ternary operator support for polymer_expressions (Closed)

Created:
6 years, 10 months ago by justinfagnani
Modified:
6 years, 10 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Ternary operator support for polymer_expressions BUG= R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=32048

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -3 lines) Patch
M pkg/polymer_expressions/lib/eval.dart View 2 chunks +29 lines, -0 lines 0 comments Download
M pkg/polymer_expressions/lib/expression.dart View 3 chunks +25 lines, -1 line 0 comments Download
M pkg/polymer_expressions/lib/parser.dart View 3 chunks +14 lines, -0 lines 0 comments Download
M pkg/polymer_expressions/lib/visitor.dart View 2 chunks +8 lines, -0 lines 0 comments Download
M pkg/polymer_expressions/test/eval_test.dart View 1 chunk +10 lines, -0 lines 2 comments Download
M pkg/polymer_expressions/test/parser_test.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/polymer_expressions/test/tokenizer_test.dart View 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
justinfagnani
6 years, 10 months ago (2014-01-27 18:02:11 UTC) #1
justinfagnani
On 2014/01/27 18:02:11, justinfagnani wrote: Fixes https://code.google.com/p/dart/issues/detail?id=12663
6 years, 10 months ago (2014-01-27 18:16:10 UTC) #2
Jennifer Messerly
LGTM with a couple of lines added to the test :) https://codereview.chromium.org/131623004/diff/1/pkg/polymer_expressions/test/eval_test.dart File pkg/polymer_expressions/test/eval_test.dart (right): ...
6 years, 10 months ago (2014-01-28 00:03:29 UTC) #3
justinfagnani
thanks! https://codereview.chromium.org/131623004/diff/1/pkg/polymer_expressions/test/eval_test.dart File pkg/polymer_expressions/test/eval_test.dart (right): https://codereview.chromium.org/131623004/diff/1/pkg/polymer_expressions/test/eval_test.dart#newcode118 pkg/polymer_expressions/test/eval_test.dart:118: expectEval('false ? 1 : false ? 2 : ...
6 years, 10 months ago (2014-01-28 01:05:21 UTC) #4
justinfagnani
6 years, 10 months ago (2014-01-28 01:47:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r32048 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698