Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Unified Diff: pkg/polymer_expressions/lib/parser.dart

Issue 131623004: Ternary operator support for polymer_expressions (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/polymer_expressions/lib/parser.dart
diff --git a/pkg/polymer_expressions/lib/parser.dart b/pkg/polymer_expressions/lib/parser.dart
index d7862661a8465f9879eaede79b4fb6d66ce8fddf..176dce76c8d822af019f7ea2832d7fb87fd21b7e 100644
--- a/pkg/polymer_expressions/lib/parser.dart
+++ b/pkg/polymer_expressions/lib/parser.dart
@@ -66,6 +66,8 @@ class Parser {
left = _makeInvokeOrGetter(left, right);
} else if (_token.kind == KEYWORD_TOKEN && _token.value == 'in') {
left = _parseComprehension(left);
+ } else if (_token.kind == OPERATOR_TOKEN && _token.value == '?') {
+ left = _parseTernary(left);
} else if (_token.kind == OPERATOR_TOKEN
&& _token.precedence >= precedence) {
left = _parseBinary(left);
@@ -124,6 +126,14 @@ class Parser {
return _parsePrimary();
}
+ Expression _parseTernary(condition) {
+ _advance(OPERATOR_TOKEN, '?');
+ var trueExpr = _parseExpression();
+ _advance(COLON_TOKEN);
+ var falseExpr = _parseExpression();
+ return _astFactory.ternary(condition, trueExpr, falseExpr);
+ }
+
Expression _parsePrimary() {
var kind = _token.kind;
switch (kind) {
@@ -152,6 +162,10 @@ class Parser {
return _parseMapLiteral();
}
return null;
+ case COLON_TOKEN:
+ // TODO(justinfagnani): We need better errors throughout the parser, and
+ // we should be throwing ParseErrors to be caught by the caller
+ throw new ArgumentError('unexpected token ":"');
default:
return null;
}

Powered by Google App Engine
This is Rietveld 408576698