Issue 1316213003: Fix tests that invoke Dart explicitly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1316213003: Fix tests that invoke Dart explicitly. (Closed)

Created:
5 years, 3 months ago by nweiz

Modified:
5 years, 3 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix tests that invoke Dart explicitly. These were passing in --package-root manually, which is no longer necessary now that pub passes --packages. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/21ac6f29ec7e0733297ff5c70ea1b3316aa0e93c

Patch Set 2 : Code review changes #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -9 lines)			Patch
	M	test/runner/runner_test.dart	View	1	3 chunks	+2 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kevmoo

LGTM w/ nit https://codereview.chromium.org/1316213003/diff/1/test/runner/runner_test.dart File test/runner/runner_test.dart (right): https://codereview.chromium.org/1316213003/diff/1/test/runner/runner_test.dart#newcode10 test/runner/runner_test.dart:10: import 'package:path/path.dart' as p; now unused ...

5 years, 3 months ago (2015-08-26 21:20:55 UTC) #2

nweiz

https://codereview.chromium.org/1316213003/diff/1/test/runner/runner_test.dart File test/runner/runner_test.dart (right): https://codereview.chromium.org/1316213003/diff/1/test/runner/runner_test.dart#newcode10 test/runner/runner_test.dart:10: import 'package:path/path.dart' as p; On 2015/08/26 21:20:55, kevmoo wrote: ...

5 years, 3 months ago (2015-08-26 21:23:27 UTC) #4

nweiz

5 years, 3 months ago (2015-08-26 21:23:30 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
21ac6f29ec7e0733297ff5c70ea1b3316aa0e93c (presubmit successful).

Expand Messages | Collapse Messages

Issue 1316213003: Fix tests that invoke Dart explicitly. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Code review changes #

Messages