Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: test/runner/runner_test.dart

Issue 1316213003: Fix tests that invoke Dart explicitly. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/runner/runner_test.dart
diff --git a/test/runner/runner_test.dart b/test/runner/runner_test.dart
index 8817b8b17001f2dff58a35dd28ed0ddb58a6b988..508b7fa65b41eac369e3d02c2a7e9240c386b44e 100644
--- a/test/runner/runner_test.dart
+++ b/test/runner/runner_test.dart
@@ -7,7 +7,6 @@
import 'dart:io';
import 'dart:math' as math;
-import 'package:path/path.dart' as p;
import 'package:scheduled_test/descriptor.dart' as d;
import 'package:scheduled_test/scheduled_stream.dart';
import 'package:scheduled_test/scheduled_test.dart';
@@ -281,10 +280,7 @@ $_usage""");
test("directly", () {
d.file("test.dart", _success).create();
- var test = runDart([
- "--package-root=${p.join(packageDir, 'packages')}",
- "test.dart"
- ]);
+ var test = runDart(["test.dart"]);
test.stdout.expect(consumeThrough(contains("All tests passed!")));
test.shouldExit(0);
@@ -331,10 +327,7 @@ $_usage""");
test("directly", () {
d.file("test.dart", _failure).create();
- var test = runDart([
- "--package-root=${p.join(packageDir, 'packages')}",
- "test.dart"
- ]);
+ var test = runDart(["test.dart"]);
test.stdout.expect(consumeThrough(contains("Some tests failed.")));
test.shouldExit(255);
});
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698