Use the stack_trace library in scheduled_test.

Use the stack_trace library in scheduled_test.

This also adds a couple features to stack_trace.

Committed: https://code.google.com/p/dart/source/detail?r=20752

[Bob Nystrom, 2013-04-01 17:30:49]

LGTM.

https://codereview.chromium.org/13157004/diff/1/pkg/scheduled_test/lib/src/sc...
File pkg/scheduled_test/lib/src/schedule.dart (right):

https://codereview.chromium.org/13157004/diff/1/pkg/scheduled_test/lib/src/sc...
pkg/scheduled_test/lib/src/schedule.dart:567: : task.toString(),
This expression is a bit dense. How about hoisting this bool out to a local
variable for clarity?

https://codereview.chromium.org/13157004/diff/1/pkg/scheduled_test/lib/src/sc...
pkg/scheduled_test/lib/src/schedule.dart:582: : child.toStringWithStackTrace(),
Ditto.

https://codereview.chromium.org/13157004/diff/1/pkg/scheduled_test/lib/src/sc...
File pkg/scheduled_test/lib/src/scheduled_future_matchers.dart (right):

https://codereview.chromium.org/13157004/diff/1/pkg/scheduled_test/lib/src/sc...
pkg/scheduled_test/lib/src/scheduled_future_matchers.dart:68: try {
Nit, but how about a blank line before the try?

https://codereview.chromium.org/13157004/diff/1/pkg/stack_trace/lib/src/trace...
File pkg/stack_trace/lib/src/trace.dart (right):

https://codereview.chromium.org/13157004/diff/1/pkg/stack_trace/lib/src/trace...
pkg/stack_trace/lib/src/trace.dart:93: /// Returns a version of [this] where
multiple stack frames matching
"a version of [this]" -> "a new Trace based on [this]"

[Bob Nystrom, 2013-04-01 17:31:28]

Side note: you should really write something up to promote stack_trace and
scheduled_test to the larger Dart community. Both really improve the user
experience and are not easy for people to implement themselves.

[nweiz, 2013-04-01 20:46:03]

I'll work on a couple emails about these libraries.

https://codereview.chromium.org/13157004/diff/1/pkg/scheduled_test/lib/src/sc...
File pkg/scheduled_test/lib/src/schedule.dart (right):

https://codereview.chromium.org/13157004/diff/1/pkg/scheduled_test/lib/src/sc...
pkg/scheduled_test/lib/src/schedule.dart:567: : task.toString(),
On 2013/04/01 17:30:49, Bob Nystrom wrote:
> This expression is a bit dense. How about hoisting this bool out to a local
> variable for clarity?

Done.

https://codereview.chromium.org/13157004/diff/1/pkg/scheduled_test/lib/src/sc...
pkg/scheduled_test/lib/src/schedule.dart:582: : child.toStringWithStackTrace(),
On 2013/04/01 17:30:49, Bob Nystrom wrote:
> Ditto.

Done.

https://codereview.chromium.org/13157004/diff/1/pkg/scheduled_test/lib/src/sc...
File pkg/scheduled_test/lib/src/scheduled_future_matchers.dart (right):

https://codereview.chromium.org/13157004/diff/1/pkg/scheduled_test/lib/src/sc...
pkg/scheduled_test/lib/src/scheduled_future_matchers.dart:68: try {
On 2013/04/01 17:30:49, Bob Nystrom wrote:
> Nit, but how about a blank line before the try?

Done.

https://codereview.chromium.org/13157004/diff/1/pkg/stack_trace/lib/src/trace...
File pkg/stack_trace/lib/src/trace.dart (right):

https://codereview.chromium.org/13157004/diff/1/pkg/stack_trace/lib/src/trace...
pkg/stack_trace/lib/src/trace.dart:93: /// Returns a version of [this] where
multiple stack frames matching
On 2013/04/01 17:30:49, Bob Nystrom wrote:
> "a version of [this]" -> "a new Trace based on [this]"

Done.

[nweiz, 2013-04-01 20:46:22]

Committed patchset #2 manually as r20752 (presubmit successful).