Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: pkg/scheduled_test/lib/src/schedule_error.dart

Issue 13157004: Use the stack_trace library in scheduled_test. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/scheduled_test/lib/src/schedule.dart ('k') | pkg/scheduled_test/lib/src/scheduled_future_matchers.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/scheduled_test/lib/src/schedule_error.dart
diff --git a/pkg/scheduled_test/lib/src/schedule_error.dart b/pkg/scheduled_test/lib/src/schedule_error.dart
index a1f8a969b0faa0946325acb5131c4a7b7f8dff46..3df208a01d353dc8821feb4976f70087f6c7bddc 100644
--- a/pkg/scheduled_test/lib/src/schedule_error.dart
+++ b/pkg/scheduled_test/lib/src/schedule_error.dart
@@ -6,6 +6,8 @@ library schedule_error;
import 'dart:async';
+import 'package:stack_trace/stack_trace.dart';
+
import 'schedule.dart';
import 'task.dart';
import 'utils.dart';
@@ -36,7 +38,7 @@ class ScheduleError extends AsyncError {
/// Creates a new [ScheduleError] wrapping [error]. The metadata in
/// [AsyncError]s and [ScheduleError]s will be preserved.
- factory ScheduleError.from(Schedule schedule, error, {stackTrace,
+ factory ScheduleError.from(Schedule schedule, error, {StackTrace stackTrace,
AsyncError cause}) {
if (error is ScheduleError) return error;
@@ -59,7 +61,8 @@ class ScheduleError extends AsyncError {
return new ScheduleError(schedule, error, stackTrace, cause);
}
- ScheduleError(Schedule schedule, error, stackTrace, AsyncError cause)
+ ScheduleError(Schedule schedule, error, StackTrace stackTrace,
+ AsyncError cause)
: super.withCause(error, stackTrace, cause),
schedule = schedule,
task = schedule.currentTask,
@@ -86,7 +89,7 @@ class ScheduleError extends AsyncError {
}
result.write('Stack trace:\n');
- result.write(prefixLines(stackTrace.toString().trim()));
+ result.write(prefixLines(terseTraceString(stackTrace)));
result.write("\n\n");
if (task != null) {
@@ -106,7 +109,7 @@ class ScheduleError extends AsyncError {
result.write("\n\n");
result.writeln("Pending out-of-band callbacks:");
for (var callback in pendingCallbacks) {
- result.writeln("* $callback");
+ result.writeln(prefixLines(callback, firstPrefix: "* "));
}
}
« no previous file with comments | « pkg/scheduled_test/lib/src/schedule.dart ('k') | pkg/scheduled_test/lib/src/scheduled_future_matchers.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698