Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1315673007: Process service events as microtasks. (Closed)

Created:
5 years, 3 months ago by turnidge
Modified:
5 years, 3 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Process service events as microtasks. This preserves the ordering among rpc responses and events. Add assertions that events are processed in order. Add a correct timestamp for Resume events when we are paused at start. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/de300cfa0e24aa33559a8625350ae86ca6d1b389

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -12 lines) Patch
M runtime/observatory/lib/service_common.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 4 chunks +10 lines, -10 lines 0 comments Download
M runtime/vm/isolate.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/service.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
turnidge
5 years, 3 months ago (2015-08-27 19:23:59 UTC) #2
Cutch
lgtm
5 years, 3 months ago (2015-08-27 19:26:08 UTC) #3
turnidge
5 years, 3 months ago (2015-08-27 19:31:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
de300cfa0e24aa33559a8625350ae86ca6d1b389 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698