Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1662)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 1315673007: Process service events as microtasks. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/service_common.dart ('k') | runtime/vm/isolate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index 5cf96c56e3248ac6e123d7918c6f959c51c4caa8..98afa8fad33330667cf96e3960cce4ad9ff2bc15 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -1283,10 +1283,11 @@ class Isolate extends ServiceObjectOwner with Coverage {
_updateBreakpoints(map['breakpoints']);
exceptionsPauseInfo = map['_debuggerSettings']['_exceptions'];
- pauseEvent = map['pauseEvent'];
- if (vm.verbose) {
- print('VM-VERBOSE: $name reloaded. pause event= $pauseEvent');
- }
+ var newPauseEvent = map['pauseEvent'];
+ assert((pauseEvent == null) ||
+ (newPauseEvent == null) ||
+ !newPauseEvent.timestamp.isBefore(pauseEvent.timestamp));
+ pauseEvent = newPauseEvent;
_updateRunState();
error = map['error'];
@@ -1338,9 +1339,6 @@ class Isolate extends ServiceObjectOwner with Coverage {
}
void _onEvent(ServiceEvent event) {
- if (vm.verbose) {
- print('VM-VERBOSE: $name _onEvent $event');
- }
switch(event.kind) {
case ServiceEvent.kIsolateStart:
case ServiceEvent.kIsolateRunnable:
@@ -1369,8 +1367,9 @@ class Isolate extends ServiceObjectOwner with Coverage {
case ServiceEvent.kPauseInterrupted:
case ServiceEvent.kPauseException:
case ServiceEvent.kResume:
+ assert((pauseEvent == null) ||
+ !event.timestamp.isBefore(pauseEvent.timestamp));
pauseEvent = event;
- print('VM-VERBOSE: $name pause event $pauseEvent');
_updateRunState();
break;
@@ -1834,10 +1833,11 @@ class ServiceEvent extends ServiceObject {
String toString() {
if (data == null) {
- return "ServiceEvent(owner='${owner.id}', kind='${kind}')";
+ return "ServiceEvent(owner='${owner.id}', kind='${kind}', "
+ "time=${timestamp})";
} else {
return "ServiceEvent(owner='${owner.id}', kind='${kind}', "
- "data.lengthInBytes=${data.lengthInBytes})";
+ "data.lengthInBytes=${data.lengthInBytes}, time=${timestamp})";
}
}
}
« no previous file with comments | « runtime/observatory/lib/service_common.dart ('k') | runtime/vm/isolate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698